Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document requirement for elevated shell on build #18180

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

GavinRay97
Copy link
Contributor

See: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Development.20flow.20for.20updating.20Extension.20for.20JVM.20language.3F/near/244023777

On Windows 10, the build fails unless you run it from an elevated prompt.
I'm unsure if Windows is even regarded as a supported development platform, certainly don't blame you if it isn't.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:48 min
[INFO] Finished at: 2021-06-26T12:59:39-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.1.0:testResources (default-testResources) on project quarkus-kubernetes-service-binding: C:\Users\rayga\Projects\tmp\quarkus\extensions\kubernetes-service-binding\runtime\target\test-classes\k8s\test-k8s\provider: A required privilege is not held by the client.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to improve the contributing guide. I added a small suggestion.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@GavinRay97
Copy link
Contributor Author

Thanks for taking the time to improve the contributing guide. I added a small suggestion.

Committed -- fair enough haha 😅

See: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Development.20flow.20for.20updating.20Extension.20for.20JVM.20language.3F/near/244023777

On Windows 10, the build fails unless you run it from an elevated prompt.
I'm unsure if Windows is even regarded as a supported development platform, certainly don't blame you if it isn't.

```ps1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:48 min
[INFO] Finished at: 2021-06-26T12:59:39-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.1.0:testResources (default-testResources) on project quarkus-kubernetes-service-binding: C:\Users\rayga\Projects\tmp\quarkus\extensions\kubernetes-service-binding\runtime\target\test-classes\k8s\test-k8s\provider: A required privilege is not held by the client.
```
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 29, 2021
@gsmet gsmet merged commit 8bf5c58 into quarkusio:main Jun 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jun 29, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 29, 2021
@gsmet
Copy link
Member

gsmet commented Jun 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants