Add RestResponse<T> type to RESTEasy Reactive #18269

FroMage · 2021-06-30T12:42:39Z

Adds the RestResponse type, which is generic with the entity type
It's a copy of the JAX-RS Response type with generics added and a few modifications
All static methods on RestResponse return a fully-built RestResponse instead of a ResponseBuilder (shortcuts)
All previous static methods which returned a builder were moved to RestResponse.ResponseBuilder allowing more complex use-cases
Added updated RestResponse.Status and RestResponse.StatusCode to list new HTTP statuses and have them as int variants (yay).
Added Response RestResponse.toResponse() to convert to a JAX-RS Response
Supported in endpoint return types, as well as exception mappers and request filters (everywhere Response was supported)

Questions/remaining:

ATM it's implemented by being a copy of the Response and impls, but perhaps it could just wrap one instead?
The existing plumbing still relies on Response, not sure if we should turn it around or not. Not sure it's worth it.
The existing JAX-RS Request (for preconditions) returns Response types, so I haven't updated the docs example to use RestResponse. We could extend it to offer variants that deal with RestResponse but given that the return type would likely be RestResponse<Void> since those status codes don't have any entity, it would likely be awkward and the endpoints using them would have to return RestResponse<?> in order to allow both variants…
I didn't look at the client support, I'm still wondering if it's worth it. I guess.
Missing support from smallrye-openapi.

quarkus-bot · 2021-06-30T12:54:59Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `8da4bc1`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

geoand · 2021-06-30T13:21:17Z

Nice! I'll take a look tomorrow!

...ment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/CustomFilterGenerator.java

michalszynkiewicz · 2021-06-30T21:25:26Z

I like it. I think it's worth having it for the client side too.

geoand · 2021-07-01T08:15:57Z

It seems like the PR needs a formatting update

geoand

I think this is great! I added some small comments

...resteasy-reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/RestResponse.java

...nt/src/test/java/io/quarkus/resteasy/reactive/server/test/response/RestResponseResource.java

geoand · 2021-07-01T08:34:20Z

extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment/pom.xml

@@ -94,6 +94,11 @@
            <artifactId>quarkus-jaxrs-client-reactive-deployment</artifactId>
            <scope>test</scope>
        </dependency>
+        <dependency>


Are you sure this works properly? Just want to make sure it doesn't create any cyclic dependencies or anything

Well, it's a test dep, and it seems to build… 🤷

geoand · 2021-07-01T08:38:04Z

Questions/remaining:

ATM it's implemented by being a copy of the Response and impls, but perhaps it could just wrap one instead?

I think it's best as is

The existing plumbing still relies on Response, not sure if we should turn it around or not. Not sure it's worth it.

I don't think it's worth it.

The existing JAX-RS Request (for preconditions) returns Response types, so I haven't updated the docs example to use RestResponse. We could extend it to offer variants that deal with RestResponse but given that the return type would likely be RestResponse<Void> since those status codes don't have any entity, it would likely be awkward and the endpoints using them would have to return RestResponse<?> in order to allow both variants…

I didn't look at the client support, I'm still wondering if it's worth it. I guess.

Yeah, it does sound useful but can definitely done in a follow-up

Missing support from smallrye-openapi.

@phillip-kruger ^

phillip-kruger · 2021-07-01T08:59:20Z

Ok great ! We can add support for it a.s.a.p. I'll open a ticket in SmallRye.
(see smallrye/smallrye-open-api#844)

quarkus-bot · 2021-07-06T09:38:44Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `679b427`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-06T09:39:44Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `5deff40`

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build	`Reclaim Disk Space`	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	`Build`	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2021-07-06T09:55:04Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `31ab415`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

geoand

💯

FroMage · 2021-07-06T12:49:35Z

Huh…

2021-07-06T09:54:43.0283096Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce (enforce-no-runtime-deps) on project quarkus-resteasy-reactive-deployment: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
2021-07-06T09:54:43.0287744Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce (enforce-no-runtime-deps) on project quarkus-resteasy-reactive-deployment: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed.
2021-07-06T09:54:43.0291388Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
2021-07-06T09:54:43.0294430Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
2021-07-06T09:54:43.0304957Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
2021-07-06T09:54:43.0308505Z     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
2021-07-06T09:54:43.0324225Z     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
2021-07-06T09:54:43.0333044Z     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
2021-07-06T09:54:43.0339067Z     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
2021-07-06T09:54:43.0341416Z     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
2021-07-06T09:54:43.0343081Z     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
2021-07-06T09:54:43.0345281Z     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
2021-07-06T09:54:43.0348088Z     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
2021-07-06T09:54:43.0349433Z     at java.lang.Thread.run (Thread.java:829)
2021-07-06T09:54:43.0351420Z Caused by: org.apache.maven.plugin.MojoExecutionException: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed.
2021-07-06T09:54:43.0353904Z     at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:260)
2021-07-06T09:54:43.0356620Z     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
2021-07-06T09:54:43.0359254Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
2021-07-06T09:54:43.0361672Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
2021-07-06T09:54:43.0364091Z     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
2021-07-06T09:54:43.0367624Z     at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
2021-07-06T09:54:43.0372072Z     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:190)
2021-07-06T09:54:43.0376464Z     at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:186)
2021-07-06T09:54:43.0379091Z     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
2021-07-06T09:54:43.0380805Z     at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515)
2021-07-06T09:54:43.0382703Z     at java.util.concurrent.FutureTask.run (FutureTask.java:264)
2021-07-06T09:54:43.0384610Z     at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
2021-07-06T09:54:43.0392353Z     at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
2021-07-06T09:54:43.0393668Z     at java.lang.Thread.run (Thread.java:829)

geoand · 2021-07-06T12:54:46Z

Likely:

2021-07-06T09:50:33.7513396Z [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-no-runtime-deps) @ quarkus-resteasy-reactive-deployment ---
2021-07-06T09:50:33.7631768Z [WARNING] Rule 0: io.quarkus.enforcer.BansRuntimeDependency failed with message:
2021-07-06T09:50:33.7633503Z 1 illegal runtime dependencies found that have to be replaced with their -deployment counterparts:
2021-07-06T09:50:33.7634648Z 	quarkus-resteasy-reactive-jackson

which is what I thought would happen because of the jackson dependency you added

FroMage · 2021-07-06T12:56:33Z

Huh, I wonder how I didn't notice this before. Fixed now, let's see.

quarkus-bot · 2021-07-06T12:57:52Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `e469be4`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

FroMage · 2021-07-06T13:01:06Z

Oh FFS. Well this is even worse now.

FroMage · 2021-07-06T13:38:09Z

OK, moved them to the jackson module. Same player shoots again.

geoand · 2021-07-06T13:42:03Z

OK, moved them to the jackson module. Same player shoots again.

Nothing but net :)

quarkus-bot · 2021-07-06T13:52:30Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f5eb90d`

Status	Name	Step	Test failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	⚠️ Check →	Logs	Raw logs

FroMage · 2021-07-06T14:01:04Z

Now, that was a majorly screwed up rebase. Took me forever to untangle it. WOW.

FroMage added the area/resteasy-reactive label Jun 30, 2021

FroMage requested review from stuartwdouglas, michalszynkiewicz and geoand June 30, 2021 12:42

quarkus-bot bot added the area/documentation label Jun 30, 2021

michalszynkiewicz reviewed Jun 30, 2021

View reviewed changes

...ment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/CustomFilterGenerator.java Outdated Show resolved Hide resolved

geoand changed the title ~~Added RestResponse<T>~~ Add RestResponse<T> type to RESTEasy Reactive Jul 1, 2021

geoand changed the title ~~Add RestResponse<T> type to RESTEasy Reactive~~ Add RestResponse<T> type to RESTEasy Reactive Jul 1, 2021

geoand reviewed Jul 1, 2021

View reviewed changes

phillip-kruger mentioned this pull request Jul 1, 2021

Add support for RestResponse smallrye/smallrye-open-api#844

Closed

FroMage force-pushed the 16718 branch 2 times, most recently from 679b427 to 5deff40 Compare July 6, 2021 09:38

FroMage force-pushed the 16718 branch from 5deff40 to 31ab415 Compare July 6, 2021 09:39

geoand approved these changes Jul 6, 2021

View reviewed changes

FroMage force-pushed the 16718 branch from 31ab415 to e469be4 Compare July 6, 2021 12:56

FroMage force-pushed the 16718 branch from e469be4 to f5eb90d Compare July 6, 2021 13:38

FroMage added 5 commits July 6, 2021 15:58

Added support for RestResponse from endpoint

ceb486f

Added support for RestResponse in ExceptionMapper

8666dca

Added support for RestResponse in request filters

9b1a5ac

Documented new RestResponse

6cfea3e

Added links to RR docs

b0a739a

FroMage force-pushed the 16718 branch from f5eb90d to b0a739a Compare July 6, 2021 14:00

FroMage merged commit e004372 into quarkusio:main Jul 7, 2021

quarkus-bot bot added this to the 2.1 - main milestone Jul 7, 2021

FroMage deleted the 16718 branch July 7, 2021 09:57

phillip-kruger mentioned this pull request Jul 22, 2021

Upgrade SmallRye OpenAPI to 2.1.8 #18938

Merged

geoand mentioned this pull request Jul 29, 2021

Not consistent json serialisation between native and not #5420

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RestResponse<T> type to RESTEasy Reactive #18269

Add RestResponse<T> type to RESTEasy Reactive #18269

FroMage commented Jun 30, 2021

quarkus-bot bot commented Jun 30, 2021 •

edited

Failing Jobs - Building `8da4bc1`

geoand commented Jun 30, 2021

michalszynkiewicz commented Jun 30, 2021

geoand commented Jul 1, 2021

geoand left a comment

geoand Jul 1, 2021

FroMage Jul 6, 2021

geoand Jul 6, 2021

geoand commented Jul 1, 2021

phillip-kruger commented Jul 1, 2021 •

edited

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `679b427`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `5deff40`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `31ab415`

geoand left a comment

FroMage commented Jul 6, 2021

geoand commented Jul 6, 2021

FroMage commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `e469be4`

FroMage commented Jul 6, 2021

FroMage commented Jul 6, 2021

geoand commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `f5eb90d`

FroMage commented Jul 6, 2021

Add RestResponse<T> type to RESTEasy Reactive #18269

Add RestResponse<T> type to RESTEasy Reactive #18269

Conversation

FroMage commented Jun 30, 2021

quarkus-bot bot commented Jun 30, 2021 • edited

Failing Jobs - Building 8da4bc1

geoand commented Jun 30, 2021

michalszynkiewicz commented Jun 30, 2021

geoand commented Jul 1, 2021

geoand left a comment

Choose a reason for hiding this comment

geoand Jul 1, 2021

Choose a reason for hiding this comment

FroMage Jul 6, 2021

Choose a reason for hiding this comment

geoand Jul 6, 2021

Choose a reason for hiding this comment

geoand commented Jul 1, 2021

phillip-kruger commented Jul 1, 2021 • edited

quarkus-bot bot commented Jul 6, 2021 • edited

Failing Jobs - Building 679b427

quarkus-bot bot commented Jul 6, 2021 • edited

Failing Jobs - Building 5deff40

quarkus-bot bot commented Jul 6, 2021 • edited

Failing Jobs - Building 31ab415

geoand left a comment

Choose a reason for hiding this comment

FroMage commented Jul 6, 2021

geoand commented Jul 6, 2021

FroMage commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 • edited

Failing Jobs - Building e469be4

FroMage commented Jul 6, 2021

FroMage commented Jul 6, 2021

geoand commented Jul 6, 2021

quarkus-bot bot commented Jul 6, 2021 • edited

Failing Jobs - Building f5eb90d

FroMage commented Jul 6, 2021

quarkus-bot bot commented Jun 30, 2021 •

edited

Failing Jobs - Building `8da4bc1`

phillip-kruger commented Jul 1, 2021 •

edited

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `679b427`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `5deff40`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `31ab415`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `e469be4`

quarkus-bot bot commented Jul 6, 2021 •

edited

Failing Jobs - Building `f5eb90d`