Qute - CompletedStage and other perf improvements #18298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Jul 1, 2021
mkouba
commented
- CompletedStage is an internal represenation of a completed computation and an optimized replacement for CompletableFuture#completedFuture()
- MultiResultNode does not allocate one more array anymore
- CompletedStage is an internal represenation of a completed computation and an optimized replacement for CompletableFuture#completedFuture() - MultiResultNode does not allocate one more array anymore
|
This PR is a follow-up of #18267. These improvements not only eliminate the remaining difference but the figures are now even better than with 1.13.7 and 2.0.0. |
gastaldi
reviewed
Jul 1, 2021
| * Note that this is not a full implementation of {@link CompletionStage} - it just throws {@link UnsupportedOperationException} | ||
| * for methods that are not used internally. Therefore, it should not be used outside the Qute API. | ||
| */ | ||
| public final class CompletedStage<T> implements CompletionStage<T>, Supplier<T> { |
There was a problem hiding this comment.
Remove the public keyword if it's not meant to be used outside this package?
There was a problem hiding this comment.
The class must be public because it's used by the generated value resolvers...
There was a problem hiding this comment.
Ah I thought it shouldn't be used or referenced besides here, gotcha
gastaldi
approved these changes
Jul 1, 2021
karesti
pushed a commit
to karesti/quarkus
that referenced
this pull request
Jul 1, 2021
Qute - CompletedStage and other perf improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.