Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS: Introduce key-store-key-password #18387

Merged
merged 1 commit into from
Jul 5, 2021
Merged

TLS: Introduce key-store-key-password #18387

merged 1 commit into from
Jul 5, 2021

Conversation

famod
Copy link
Member

@famod famod commented Jul 4, 2021

The ability to set such a key-specific password was added to vert.x 4.1.1 via eclipse-vertx/vert.x#3970 / eclipse-vertx/vert.x#3982

See also #17884 which added the alias.

The only change to server-keystore.jks is "serverpw" instead of "password" for the entry with name "server".

@famod
Copy link
Member Author

famod commented Jul 4, 2021

@geoand @michalszynkiewicz I think both alias and password could be interesting for the RR client (ClientBuilderImpl, AFAICS).

The same might apply to VertxSpringCloudConfigGateway, GrpcSslUtils and VertxConsulConfigGateway as well.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 5, 2021

Failing Jobs - Building fa325a3

Status Name Step Test failures Logs Raw logs
MicroProfile TCKs Tests Verify Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

@geoand
Copy link
Contributor

geoand commented Jul 5, 2021

@geoand @michalszynkiewicz I think both alias and password could be interesting for the RR client (ClientBuilderImpl, AFAICS).

The same might apply to VertxSpringCloudConfigGateway, GrpcSslUtils and VertxConsulConfigGateway as well.

Yeah, I think we've discussed similar things in the past :)

@famod
Copy link
Member Author

famod commented Jul 5, 2021

@cescoffier it seems you are ok with the PR as is? If yes, can you approve please?
Please let me know if there is anything left to look into. Thanks!

/cc @sberyozkin in case you are want to have a look as well...

@cescoffier
Copy link
Member

@famod Yes, let me update my review.

@famod
Copy link
Member Author

famod commented Jul 5, 2021

That one FT test failure looks flaky to me:

Bulkhead[org.eclipse.microprofile.fault.tolerance.tck.timeout.clientserver.UninterruptableTimeoutClient#serviceTimeoutAsyncBulkhead] rejected from bulkhead

/cc @Ladicek

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@famod famod merged commit 25a7611 into quarkusio:main Jul 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 5, 2021
@famod famod deleted the key-password branch July 5, 2021 17:22
@famod
Copy link
Member Author

famod commented Jul 5, 2021

Thanks all!

@Ladicek
Copy link
Contributor

Ladicek commented Jul 15, 2021

@famod Yes, TimeoutUninterruptableTest.testTimeoutAsyncBulkhead is flaky (see also smallrye/smallrye-fault-tolerance#233). It doesn't fail often, and I didn't see it failing locally or in SmallRye Fault Tolerance CI, so I've neglected investigating it. Sorry about that! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants