Unclutter dev mode logging #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we end up with the following log message in dev mode: WARN [io.qua.config] Unrecognized configuration key "quarkus.undertow.resources" provided
It allows to get the log cleanup filters set. If startup fails, we activate the delayed handler to flush the messages.
|
@johnaohara I think I addressed the initial issue you had in #1375 in a more conservative way. Could you check it's OK for you? |
|
@gsmet this approach is the approach suggested by @stuartwdouglas. I will confirm that #1363 is resolved by this change |
|
@johnaohara yes, so it's not exactly the approach you discussed in the issue as it's not a shutdown hook. I just flush the messages if we have an error. |
dmlloyd
approved these changes
Apr 3, 2019
johnaohara
approved these changes
Apr 3, 2019
|
Everyone is happy, merging then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quarkus.undertow.resourcestoquarkus-internal.undertow.resourcesto avoid an unrecognized config log messageFixes #1764
Fixes #1803
Also fixes #1393 as it was introduced by #1375