Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OidcClient to accept String expires_in values #18415

Merged

Conversation

sberyozkin
Copy link
Member

Fixes #18374

Standard expires_in value is a JSON number (long) however some providers may return it as JSON String. This PR, instead of immediately retrieving it as Long, casts it to Long if the property is an instance of Long otherwise converts a String representation to Long.

One of the oidc_client_wiremock tests has been updated to check it (there is another test there which deals with Long)

CC @chiragrp

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 851851f

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@sberyozkin sberyozkin force-pushed the oidc_client_expires_in_string branch from e5ded42 to 95a6fab Compare July 5, 2021 13:41
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building e5ded42

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 95a6fab

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@sberyozkin sberyozkin force-pushed the oidc_client_expires_in_string branch from f3ea4bd to d233b01 Compare July 5, 2021 13:46
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 5, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building f3ea4bd

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Cache Maven Repository ⚠️ Check → Logs Raw logs
CI Sanity Check Build ⚠️ Check → Logs Raw logs

@sberyozkin
Copy link
Member Author

sberyozkin commented Jul 5, 2021

Thanks @gastaldi, it should be most optimal, the way you have proposed

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sberyozkin
Copy link
Member Author

Thanks @geoand

@sberyozkin
Copy link
Member Author

Thanks @gastaldi

@sberyozkin sberyozkin merged commit 838e9db into quarkusio:main Jul 5, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 5, 2021
@sberyozkin sberyozkin deleted the oidc_client_expires_in_string branch July 5, 2021 14:37
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.1.Final Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus OIDC Client unable to retrieve access-token
4 participants