Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matchers to in flaky DevMojoIT in order to get proper logs when the test fails #18437

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 6, 2021

Relates to: #16524

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 6, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building d93d210

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
Initial JDK 11 Build Build ⚠️ Check → Logs Raw logs

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 6, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1f1ddc0

Status Name Step Test failures Logs Raw logs
Maven Tests - JDK 11 Build Test failures Logs Raw logs
Maven Tests - JDK 11 Windows Build Test failures Logs Raw logs

Full information is available in the Build summary check run.

Test Failures

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 843 - More details - Source on GitHub


⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed line 843 - More details - Source on GitHub


// Update the resource
String uuid = UUID.randomUUID().toString();
FileUtils.write(source, uuid, "UTF-8");
await()
.pollDelay(100, TimeUnit.MILLISECONDS)
.atMost(1, TimeUnit.MINUTES)
.until(() -> DevModeTestUtils.getHttpResponse("/lorem.txt").contains(uuid));
.until(() -> DevModeTestUtils.getHttpResponse("/lorem.txt"), equalTo(uuid));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the meaning here. That's what you wanted to do?

Copy link
Contributor Author

@geoand geoand Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is

@gsmet gsmet merged commit 8d14845 into quarkusio:main Jul 6, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 6, 2021
@geoand geoand deleted the #16524 branch July 6, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants