CLI registry clear-cache command

[aloubyansky]

An attempt to add registry clear-cache CLI command to clear the local registry cache.

Other registry sub-commands could include:

• list to list currently enabled registries;
• add to add another registry to the devtools config;
• remove to remove a registry from the config;
• disable to temporarily disable a registry in the config;
• enable to (re-)enable a registry in the config.

A config file could be either a global (in the user home dir) or in the project dir.

[maxandersen]

A config file could be either a global (in the user home dir) or in the project dir.

what does "in project dir" means in a multimodule project ?

[maxandersen]

btw. +1 on having registry command for add/remove etc. but shouldn't clear-cache more be something doable by a flag on a command that uses the registry ?

i.e. quarkus create --clean-registry-cache or similar ?

[aloubyansky]

A config file could be either a global (in the user home dir) or in the project dir.

what does "in project dir" means in a multimodule project ?

The root project dir.

[aloubyansky]

btw. +1 on having registry command for add/remove etc. but shouldn't clear-cache more be something doable by a flag on a command that uses the registry ?

i.e. quarkus create --clean-registry-cache or similar ?

I'd personally prefer a separate command. It could have more arguments, e.g. clear cache for a specific registry, clear cache for platform catalog only, for a particular stream, etc. The impl in this PR is cleaning everything.

[aloubyansky]

[aloubyansky@localhost test]$ qs registry
Available Quarkus extension registries:
registry.quarkus.io

[aloubyansky@localhost test]$ qs registry list
Available Quarkus extension registries:
registry.quarkus.io

[aloubyansky@localhost test]$ qs registry --refresh
Refreshing the local extension catalog cache of registry.quarkus.io
Available Quarkus extension registries:
registry.quarkus.io

[aloubyansky@localhost test]$ qs registry list --refresh
Refreshing the local extension catalog cache of registry.quarkus.io
Available Quarkus extension registries:
registry.quarkus.io

With debug enabled in the .quarkus/config.yaml

[aloubyansky@localhost test]$ qs registry list --refresh
Refreshing the local extension catalog cache of registry.quarkus.io
Downloading from registry.quarkus.io: https://registry.quarkus.io/maven/io/quarkus/registry/quarkus-registry-descriptor/1.0-SNAPSHOT/maven-metadata.xml
Downloaded from registry.quarkus.io: https://registry.quarkus.io/maven/io/quarkus/registry/quarkus-registry-descriptor/1.0-SNAPSHOT/maven-metadata.xml (736 B at 942 B/s)
Downloading from registry.quarkus.io: https://registry.quarkus.io/maven/io/quarkus/registry/quarkus-registry-descriptor/1.0-SNAPSHOT/quarkus-registry-descriptor-1.0-20210713.112505-1.json
Downloaded from registry.quarkus.io: https://registry.quarkus.io/maven/io/quarkus/registry/quarkus-registry-descriptor/1.0-SNAPSHOT/quarkus-registry-descriptor-1.0-20210713.112505-1.json (470 B at 2.1 kB/s)
Available Quarkus extension registries:
registry.quarkus.io

[ebullient]

Should the BaseRegistryCommand also bring in the RegistryClient mixin? And shouldn't that mixin be used to find the catalog resolver so that it is consistent?

[aloubyansky]

The registry command isn't actually using the registry client. At least at this point. It's basically a config reading/editing command.

[ebullient]

QuarkusProjectHelper.getCatalogResolver().clearRegistryCache(); -- that is what the RegistryClient currently encapsulates (discovery of CatalogResolver based on what it knows about the project and/or global config)

[aloubyansky]

Perhaps, once we enable the registry client by default that could make more sense. While all of this is related to the registry client, the RegistryClientMixin is currently used to provide the --registry-client option and QuarkusProject with an ExtensionCatalog. Atm, none of that is relevant for the registry command.

[ebullient]

hmm. true. but would/should --refresh apply everywhere that the registry client is used? (this gets back to @maxandersen comment earlier/somewhere)

[aloubyansky]

Not sure about that.

[aloubyansky]

Ok, refactored to add the --refresh option to the RegistryClientMixin.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building 1b3a408

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build		⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number		⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check		⚠️ Check →	Logs	Raw logs

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building d6ffeba

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status	Name	Step	Test failures	Logs	Raw logs
⌛	Initial JDK 11 Build		⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number		⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check		⚠️ Check →	Logs	Raw logs