Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix injection of indexed based configuration #18491

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix injection of indexed based configuration #18491

merged 1 commit into from
Jul 7, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 7, 2021

Fixes: #18473

@geoand geoand requested review from mkouba and radcortez July 7, 2021 14:42
@geoand geoand mentioned this pull request Jul 7, 2021
Closed
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Jul 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 7, 2021

Failing Jobs - Building fe4c3eb

Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun line 44 - More details - Source on GitHub

@geoand geoand merged commit 80a04f0 into quarkusio:main Jul 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 7, 2021
@geoand geoand deleted the #18473 branch July 8, 2021 06:34
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.2.Final Jul 12, 2021
@gsmet gsmet modified the milestones: 2.0.2.Final, 2.1 - main Jul 12, 2021
@gsmet
Copy link
Member

gsmet commented Jul 12, 2021

I wasn't able to backport this one, I got:

Caused by: java.util.NoSuchElementException: SRCFG00014: The config property server.hosts is required but it could not be found in any config source

I wonder if it's dependent on the SmallRye Config upgrades or other changes we have in main.

@radcortez
Copy link
Member

Maybe SR Config. Can't remember anything in particular in main. Should we search for it, or just assume this is not be backported?

@gsmet
Copy link
Member

gsmet commented Jul 13, 2021

I think it can wait for 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcortez radcortez radcortez approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

Indexed configuration properties not injected by @ConfigProperty
3 participants
@geoand @gsmet @radcortez