Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also look for DOCKER_HOST in IsDockerWorking #18505

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Also look for DOCKER_HOST in IsDockerWorking #18505

merged 1 commit into from
Jul 8, 2021

Conversation

stuartwdouglas
Copy link
Member

Fixes #18494

@quarkus-bot quarkus-bot bot added the area/core label Jul 7, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2021

Failing Jobs - Building 1ee2796

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
⌛ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 16

@stuartwdouglas
Copy link
Member Author

I don't actually have any way to test this locally so I have asked the original reported to test it.

@gsmet
Copy link
Member

gsmet commented Jul 8, 2021

OP confirmed the fix, let's merge.

@gsmet gsmet merged commit 417d152 into quarkusio:main Jul 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 8, 2021
@Sanne
Copy link
Member

Sanne commented Jul 8, 2021

Nice, I was about to report a related issue :) It looks like this might solve it, I'll check

@Sanne Sanne mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

Dev Services with a remote Docker environment
4 participants
@stuartwdouglas @gsmet @Sanne @geoand