Unify console color handling #18506
Merged
Unify console color handling #18506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jul 8, 2021
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building d276427
|
|
This workflow status is outdated as a new workflow run has been triggered. |
geoand
approved these changes
Jul 8, 2021
gsmet
added
the
triage/needs-rebase
|
This needs a rebase. |
- quarkus.console.color is now the canonical source of color - quarkus.logging.console.color is now deprecated (same as quarkus.test.disable-color) - If color is disable the advanced ANSI console will also be disabled Previously color was only the concern of logging, but now that we have the continuous testing console it also matters for the testing console. Fixes quarkusio#18288
stuartwdouglas
added
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
rolfedh
added a commit
to rolfedh/quarkus
that referenced
this pull request
May 16, 2023
rolfedh
added a commit
to rolfedh/quarkus
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quarkus.test.disable-color)
Previously color was only the concern of logging, but now that we have
the continuous testing console it also matters for the testing console.
Fixes #18288