Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds [App]ArtifactKey.toGacString() method to strip the type from the string #18519

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

aloubyansky
Copy link
Member

Switching from JsonInclude.Include.NON_EMPTY to JsonInclude.Include.NON_DEFAULT also gets rid of the empty arrays in the json (but once we upgrade to the next version of the quarkus-platform-bom-maven-plugin).

@aloubyansky aloubyansky requested a review from gastaldi July 8, 2021 10:25
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 8, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building a8d13c2

Status Name Step Test failures Logs Raw logs
JVM Tests - JDK 11 Build Test failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides - More details - Source on GitHub


⚙️ JVM Tests - JDK 11 Windows #

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides - More details - Source on GitHub

@aloubyansky
Copy link
Member Author

This has revealed a bug in our Gradle plugin related to dependency handling.

@aloubyansky
Copy link
Member Author

@glefloch fyi, the second commit is supposed to fix the parsing of dependency conditions and checking whether they are satisfied.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 8, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 4d7b362

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/resteasy-reactive-rest-client

io.quarkus.it.rest.client.BasicTest.shouldMakeJsonRequest line 40 - More details - Source on GitHub

@aloubyansky aloubyansky merged commit 7c21fda into quarkusio:main Jul 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 9, 2021
@gsmet
Copy link
Member

gsmet commented Jul 12, 2021

I only backported the first commit, the second commit is not backportable as the feature is not in 2.0.

@gsmet gsmet modified the milestones: 2.1 - main, 2.0.2.Final Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants