-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds [App]ArtifactKey.toGacString() method to strip the type from the string #18519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building a8d13c2
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 devtools/cli✖ ⚙️ JVM Tests - JDK 11 Windows #📦 devtools/cli✖ |
This has revealed a bug in our Gradle plugin related to dependency handling. |
a8d13c2
to
4d7b362
Compare
@glefloch fyi, the second commit is supposed to fix the parsing of dependency conditions and checking whether they are satisfied. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 4d7b362
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 Windows #📦 integration-tests/resteasy-reactive-rest-client✖ |
4d7b362
to
defa754
Compare
I only backported the first commit, the second commit is not backportable as the feature is not in 2.0. |
Switching from
JsonInclude.Include.NON_EMPTY
toJsonInclude.Include.NON_DEFAULT
also gets rid of the empty arrays in the json (but once we upgrade to the next version of thequarkus-platform-bom-maven-plugin
).