Fix lambda http base64 encoding and binary types #18532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriot1burke
force-pushed
the
lambda-base64
branch
from
57c67ac
to
b2287a8
Compare
|
This workflow status is outdated as a new workflow run has been triggered. |
patriot1burke
force-pushed
the
lambda-base64
branch
from
b2287a8
to
5908d12
Compare
|
This workflow status is outdated as a new workflow run has been triggered. |
kenyee
approved these changes
Jul 9, 2021
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
...mazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Show resolved
Hide resolved
gastaldi
reviewed
Jul 9, 2021
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Jul 9, 2021
...mazon-lambda-rest/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
patriot1burke
force-pushed
the
lambda-base64
branch
from
5908d12
to
0b05104
Compare
gastaldi
reviewed
Jul 9, 2021
...mazon-lambda-http/runtime/src/main/java/io/quarkus/amazon/lambda/http/LambdaHttpHandler.java
Outdated
Show resolved
Hide resolved
patriot1burke
force-pushed
the
lambda-base64
branch
from
0b05104
to
a0273e6
Compare
finish base64 remove unneeded lambda source fix encoding ROOT fix simpler
patriot1burke
force-pushed
the
lambda-base64
branch
from
a0273e6
to
730e2b7
Compare
cescoffier
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lambda http/rest plugins were not correctly base64 encoding binary types. Also, treat everything as a binary type unless it is "text", xml", "json", or "yaml".