Dev tools: tests for adding extensions from different platform members #18535
Conversation
quarkus-bot
bot
added
area/devtools
aloubyansky
force-pushed
the
registry-client-testing
branch
from
b62bf6c
to
6f894e1
Compare
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building b62bf6c
Full information is available in the Build summary check run. Test Failures⚙️ Devtools Tests - JDK 11 #📦 integration-tests/devtools✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Devtools Tests - JDK 11 Windows #📦 integration-tests/devtools✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6f894e1
Full information is available in the Build summary check run. Test Failures⚙️ Devtools Tests - JDK 11 #📦 integration-tests/devtools✖ ✖ ✖ ⚙️ Devtools Tests - JDK 11 Windows #📦 integration-tests/devtools✖ ✖ ✖ |
aloubyansky
force-pushed
the
registry-client-testing
branch
from
6f894e1
to
ad9409a
Compare
aloubyansky
force-pushed
the
registry-client-testing
branch
from
ad9409a
to
e03ad3e
Compare
Failing Jobs - Building e03ad3e
Full information is available in the Build summary check run. Test Failures⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖ |
| sawFirstPlatform = true; | ||
| } | ||
| platformBoms.add(c.getBom()); | ||
| } | ||
| } else if (ElementCatalogBuilder.hasElementCatalog(mainCatalog)) { |
There was a problem hiding this comment.
Yes, it's checking whether there is an "element" catalog attached to the mainCatalog. A bit of a hack but that's how it is for now.
There was a problem hiding this comment.
I meant, it would be better to move this whole block to a specific method.
But I know you love those long methods 🤪
| @@ -41,7 +41,7 @@ public QuarkusCommandOutcome execute(QuarkusCommandInvocation invocation) throws | |||
| final MessageWriter log = invocation.log(); | |||
| final boolean all = invocation.getValue(ListExtensions.ALL, true); | |||
| final boolean installedOnly = invocation.getValue(ListExtensions.INSTALLED, false); | |||
| final boolean cli = invocation.getValue(ListExtensions.FROM_CLI, false); | |||
| //final boolean cli = invocation.getValue(ListExtensions.FROM_CLI, false); | |||
Basic tests for adding extensions to existing projects that belong to platform members whose BOMs haven't been imported yet.
The testsuite is still building up and will need to be properly organized.