Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use code instead of provides-code as extension tag #18568

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Use code instead of provides-code as extension tag #18568

merged 1 commit into from
Jul 13, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Jul 9, 2021 •
edited

This is related to quarkusio/code.quarkus.io#485

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 9, 2021
@ia3andy ia3andy requested a review from aloubyansky July 9, 2021 13:40
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 9, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 9b0cad4

Status Name Step Test failures Logs Raw logs
✖ Devtools Tests - JDK 11 Build Test failures Logs Raw logs
✖ Devtools Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 16

Full information is available in the Build summary check run.

Test Failures

⚙️ Devtools Tests - JDK 11 #

📦 integration-tests/devtools

✖ io.quarkus.platform.catalog.ExtensionProcessorTest.testRESTEasyMetadata line 22 - More details - Source on GitHub

⚙️ Devtools Tests - JDK 11 Windows #

📦 integration-tests/devtools

✖ io.quarkus.platform.catalog.ExtensionProcessorTest.testRESTEasyMetadata line 22 - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/grpc/deployment

✖ io.quarkus.grpc.server.devmode.GrpcDevModeTest.testProtoFileChangeReload line 127 - More details - Source on GitHub

📦 extensions/resteasy-reactive/jaxrs-client-reactive/deployment

✖ io.quarkus.jaxrs.client.reactive.deployment.test.UniInvokerTestCase.testInjection line 48 - More details - Source on GitHub

gsmet
gsmet requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should also be updated.

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 12, 2021 •
edited

Tests should also be updated.

@gsmet Sometime I am wondering if you are not a Quarkus bot 😂

@gsmet gsmet merged commit 6bdbf1b into quarkusio:main Jul 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 13, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.2.Final Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
2.0.2.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ia3andy @aloubyansky @gsmet