Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle: look for extension properties only in JARs #18581

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Gradle: look for extension properties only in JARs #18581

merged 1 commit into from
Jul 9, 2021

Conversation

aloubyansky
Copy link
Member

It's not uncommon to see, e.g. a pom artifact among the dependencies.

@aloubyansky aloubyansky requested a review from glefloch July 9, 2021 19:36
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jul 9, 2021
glefloch
glefloch approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good to me

@glefloch glefloch merged commit 7418262 into quarkusio:main Jul 9, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 9, 2021
@gsmet
Copy link
Member

gsmet commented Jul 12, 2021

Not backporting, this code is not in 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glefloch glefloch glefloch approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aloubyansky @gsmet @glefloch