Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for quarkus.package.type=native-sources #18589

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Added documentation for quarkus.package.type=native-sources #18589

merged 1 commit into from
Jul 12, 2021

Conversation

turing85
Copy link
Contributor

No description provided.

geoand
geoand reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I added some suggestions

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
gsmet
gsmet previously requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the suggestions are applied, this will need a squash. Thanks.

@turing85
Copy link
Contributor Author

Once the suggestions are applied, this will need a squash. Thanks.

@gsmet done.

geoand
geoand approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand dismissed gsmet’s stale review July 12, 2021 11:49

comment addressed

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
@Sanne Sanne merged commit 725fe72 into quarkusio:main Jul 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 12, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet left review comments

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.1.0.CR1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@turing85 @gsmet @geoand @Sanne