Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Throwable handling in @ServerExceptionMapper #18613

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix Throwable handling in @ServerExceptionMapper #18613

merged 1 commit into from
Jul 12, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 12, 2021

Fixes: #18603

@geoand geoand requested a review from FroMage July 12, 2021 13:58
@geoand geoand mentioned this pull request Jul 12, 2021
Closed
FroMage
FroMage requested changes Jul 12, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually fine with this, but are you sure the opentelemetry change should be committed too?

@geoand
Copy link
Contributor Author

geoand commented Jul 12, 2021

Darn IDE... I changed things without me noticing...

I'll fix it in a while

@FroMage
Copy link
Member

FroMage commented Jul 12, 2021

Darn IDE... I changed things without me noticing...

Look man, please keep doing this, at least I'm not the only one all the time ;)

@geoand
Copy link
Contributor Author

geoand commented Jul 12, 2021

Hahahaha 🤣

@gsmet
Copy link
Member

gsmet commented Jul 12, 2021

I added the backport label as I might release a 2.0.2 tomorrow because I like symmetry.

@geoand geoand requested a review from FroMage July 12, 2021 15:07
@geoand
Copy link
Contributor Author

geoand commented Jul 12, 2021

I added the backport label as I might release a 2.0.2 tomorrow because I like symmetry.

That's great to know, thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 12, 2021 •
edited

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building a559cf7

⚠️ Artifacts of the workflow run were not available thus the report misses some details.

Status Name Step Test failures Logs Raw logs
⌛ Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
@geoand geoand merged commit a4c40ca into quarkusio:main Jul 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 12, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
@gsmet gsmet modified the milestones: 2.1 - main, 2.0.2.Final Jul 12, 2021
@geoand geoand deleted the #18603 branch July 13, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/documentation area/resteasy-reactive
Projects
None yet
Milestone
2.0.2.Final
Development

Successfully merging this pull request may close these issues.

StackOverflowException for Throwable ExceptionMapper
3 participants
@geoand @FroMage @gsmet