Allows configuring the mailer trust store #18616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jul 12, 2021
geoand
reviewed
Jul 12, 2021
extensions/mailer/runtime/src/main/java/io/quarkus/mailer/runtime/MailConfig.java
Outdated
Show resolved
Hide resolved
geoand
reviewed
Jul 12, 2021
In addition: - add pipelining, allowRcpErrirs, pool cleaner, and keep alive timeout configuration support. - add support for NTLM - update config item JavaDoc and extend accepted values when Vert.x 4 added feature
cescoffier
force-pushed
the
mailer-trust-store
branch
from
f28cb96
to
e8d4ab1
Compare
|
This workflow status is outdated as a new workflow run has been triggered. |
geoand
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18329.
Add support for trust store configuration to the Quarkus mailer.
Note that the trust store was already configurable but was using odd properties (key-store and key-store-password). If was only supporting JKS. This PR adds support for PEM and PCK#12 (in addition to JKS).
Also: