-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Registry client integration tests #18631
Conversation
}, | ||
{ | ||
"category": "DevTools Integration Tests", | ||
"timeout": 70, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70 minutes? How long does it take on average?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2-3 minutes, maybe I should lower that a bit :)
So right now the JVM test execution will take place in the JVM test jobs, not in the Devtools test jobs. Is that what you want? |
Yes, I believe so. The Devtools test job created in this PR is meant to run native tests only |
@gastaldi What I mean is that CI has two separate
So, my point is that it might be confusing that (some) devtools tests are not run in the dedicated devtools jobs, but in the JVM jobs instead. /cc @gsmet If you all think that's ok it'll be ok for me too, it's only a minor thing after all. |
I think it makes sense to add this test to the existing devtools jobs. |
AFAIU the main reason why I didn't add to the |
Could we add it to the existing jobs though? |
We could, but needs a bit of tweaking. E.g. the grep statements in the calculation job need adjusment, as well as the project selection in the devtools job and the project-deselection in the JVM tests job. |
Deselection |
I can have a look, but not before the weekend I think. |
No description provided.