Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry client integration tests #18631

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

gastaldi
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jul 12, 2021
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 12, 2021
},
{
"category": "DevTools Integration Tests",
"timeout": 70,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

70 minutes? How long does it take on average?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2-3 minutes, maybe I should lower that a bit :)

@famod
Copy link
Member

famod commented Jul 12, 2021

So right now the JVM test execution will take place in the JVM test jobs, not in the Devtools test jobs. Is that what you want?

@gastaldi
Copy link
Contributor Author

gastaldi commented Jul 13, 2021

So right now the JVM test execution will take place in the JVM test jobs, not in the Devtools test jobs. Is that what you want?

Yes, I believe so. The Devtools test job created in this PR is meant to run native tests only

@geoand geoand merged commit 380d0d6 into quarkusio:main Jul 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 13, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 13, 2021
@famod
Copy link
Member

famod commented Jul 13, 2021

@gastaldi What I mean is that CI has two separate Devtools Tests jobs (one for linux and one for windows). Those jobs are only executing integration-tests/devtools but not this new module here.
Together with the rest of the CI setup, this is now run in the three JVM Test jobs:

[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ quarkus-integration-test-devtools-registry-client ---
[INFO] Surefire report directory: /home/runner/work/quarkus/quarkus/integration-tests/devtools-registry-client/target/surefire-reports
[INFO] 
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.quarkus.registry.RegistryConfigTest
2021-07-12 20:58:55,138 INFO  [io.quarkus] (main) Quarkus 999-SNAPSHOT on JVM started in 2.307s. Listening on: http://localhost:8081
2021-07-12 20:58:55,140 INFO  [io.quarkus] (main) Profile test activated. 
2021-07-12 20:58:55,140 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy, resteasy-jackson, smallrye-context-propagation]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.625 s - in io.quarkus.registry.RegistryConfigTest
2021-07-12 20:58:57,258 INFO  [io.quarkus] (main) Quarkus stopped in 0.064s

So, my point is that it might be confusing that (some) devtools tests are not run in the dedicated devtools jobs, but in the JVM jobs instead. /cc @gsmet

If you all think that's ok it'll be ok for me too, it's only a minor thing after all.

@aloubyansky
Copy link
Member

I think it makes sense to add this test to the existing devtools jobs.

@gastaldi gastaldi deleted the registry_it branch July 13, 2021 09:24
@gastaldi
Copy link
Contributor Author

gastaldi commented Jul 13, 2021

AFAIU the main reason why I didn't add to the integration-tests/devtools module is because it does not run or contain native tests, so I decided to not mess with that by putting in another module.

@aloubyansky
Copy link
Member

Could we add it to the existing jobs though?

@famod
Copy link
Member

famod commented Jul 13, 2021

We could, but needs a bit of tweaking.

E.g. the grep statements in the calculation job need adjusment, as well as the project selection in the devtools job and the project-deselection in the JVM tests job.
Parts of that would be easier if we had a hierarchy, e.g. integration-tests/devtools with main and registry-client underneath (or similar)

@famod
Copy link
Member

famod commented Jul 13, 2021

Deselection -pl!... isn't recursive though, so we'd need to list all devtool modules.
A trick would be to put modules in the devtools IT parent in a profile that can be switched off.
Doing that one level up for all ITs would be rather verbose given the number of modules.

@famod
Copy link
Member

famod commented Jul 13, 2021

I can have a look, but not before the weekend I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants