Make @QuarkusIntegrationTest work reliably with testcontainers launched services #18653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed services As services launched with testcontainers (which are under user-control, not ours) will use localhost as the host they present to the relevant Quarkus configuration, the only way to reliably make the application container work with these, is to use host networking
|
We will definitely want this in |
gastaldi
approved these changes
Jul 13, 2021
geoand
added
triage/backport?
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As services launched with testcontainers (which are under user-control, not ours)
will use localhost as the host they present to the relevant Quarkus configuration,
the only way to reliably make the application container work with these, is to
use host networking.
See https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/testcontainers.20networking.20in.20docker.20mode for a thorough discussion