Unless configured, derive the registry URL from the registry ID #18661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
gastaldi
approved these changes
Jul 13, 2021
gastaldi
reviewed
Jul 13, 2021
|
|
||
| private static RegistriesConfig serializeDeserialize(RegistriesConfig config) throws Exception { | ||
| final StringWriter buf = new StringWriter(); | ||
| try (BufferedWriter writer = new BufferedWriter(buf)) { |
There was a problem hiding this comment.
No need to use BufferedWriter to write to a StringWriter
There was a problem hiding this comment.
It's a habit, I didn't even think about it apparently. Removed.
gastaldi
reviewed
Jul 13, 2021
| try (BufferedWriter writer = new BufferedWriter(buf)) { | ||
| RegistriesConfigMapperHelper.toYaml(config, writer); | ||
| } | ||
| try (BufferedReader reader = new BufferedReader(new StringReader(buf.toString()))) { |
There was a problem hiding this comment.
No need to use a BufferedReader to read from a StringReader
aloubyansky
force-pushed
the
registry-client-testing
branch
from
745e0ad
to
23a61b4
Compare
|
This workflow status is outdated as a new workflow run has been triggered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the fallback to the Sonatype's OSS snapshot repo in case the repo URL has not been configured for now and uses the
https://<registry-id>/mavenas the default registry repository URL.