Fix OpenTelemetry late bound span processors

[kenfinnigan]

• Fixes Custom OpenTelemetry SpanExporter breaks Jaeger exporter #18575
• Changes default in LateBoundBatchSpanProcessor for isEndRequired() to true. In multiple span processor situation, this is necessary to ensure spans are reported

[kenfinnigan]

@hacst could you verify this fixes it for you?

I've verified locally and I think it's good, but would be great to have additional verification

[ebullient]

@hacst could you verify this fixes it for you?

I've verified locally and I think it's good, but would be great to have additional verification

is there any way to add this to automated tests?

[kenfinnigan]

It would require an example with multiple exporters present, so likely a whole other module

[hacst]

Thanks a lot for the fix. I'll have to look into how to build a custom quarkus version to test this (or are there Nightly builds in some repository I am unaware of?). Will try to do so tomorrow.

[kenfinnigan]

@hacst not sure if there are nightlies or not.

The easiest way is to check out either the PR, or my branch with the fix, and then run mvn -Dquickly to build it. Update any example to use 999-SNAPSHOT and quarkus-bom instead of quarkus-universe-bom and I think that's it

[hacst]

I verified that a Quarkus with this fix resolves the issue in my testing. Thanks a lot.

[hacst]

@kenfinnigan while the issue is gone (export works) I still see the warning in the log on startup (tried only with dev server):

2021-07-16 09:50:38,849 WARN  [io.qua.ope.exp.jae.run.LateBoundBatchSpanProcessor] (Quarkus Main Thread) No BatchSpanProcessor delegate specified, no action taken.

Is that expected?

[kenfinnigan]

@hacst Likely yes, as all it means is the first time the late bound is accessed the delegate isn't present, probably during instantiation of the MultiSpanProcessor, but subsequent span processing is fine because the delegate is then set.

It might be possible to tweak things in the multi processor situation to not output the message, but it would require investigation and may not be possible