Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis dev mode #18704

Merged
merged 1 commit into from Jul 15, 2021
Merged

Fix Redis dev mode #18704

merged 1 commit into from Jul 15, 2021

Conversation

stuartwdouglas
Copy link
Member

Fixes #18669

@gsmet
Copy link
Member

gsmet commented Jul 15, 2021

@stuartwdouglas I'm not sure I understand why it didn't work before? I also wouldn't be surprised we use the exact same pattern elsewhere.

@gsmet gsmet merged commit 7750403 into quarkusio:main Jul 15, 2021
@quarkus-bot quarkus-bot bot added this to the 2.1 - main milestone Jul 15, 2021
@stuartwdouglas
Copy link
Member Author

There was an @PreDestroy on something that was not a CDI bean

@gsmet
Copy link
Member

gsmet commented Jul 15, 2021

Ah yeah OK, I missed that. I think it used to be a CDI bean but got changed at some point. I wonder if we could detect than somehow and throw at least a warning if not an error. @mkouba WDYT?

@mkouba
Copy link
Contributor

mkouba commented Jul 15, 2021

I wonder if we could detect than somehow and throw at least a warning if not an error.

Detect what exactly? That there's a @PreDestroy declared on a class which is not a bean? We could definitely do that. But I'm not quite sure we should throw an error because it comes from javax.annotation and thus can be used by other frameworks and libraries, i.e. it's not CDI-only.

@stuartwdouglas
Copy link
Member Author

Yea, it's not really practical. It's possible to have classes in extensions that are only sometimes registered as beans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis breaks on live reload
3 participants