Upgrade Smallrye Reactive Messaging to 3.8.0 #18972

ozangunalp · 2021-07-23T15:26:12Z

Wire startup probe
Update documentation for health checks and record key propagation
Copy up-to-date configuration documentation from reactive messaging.

Ladicek · 2021-07-23T16:33:14Z

docs/src/main/asciidoc/smallrye-kafka-incoming.adoc

+
+| *group.id* | A unique string that identifies the consumer group the application belongs to. If not set, a unique, generated id is used
+
+Type: _string_ | false | 


We need to figure out this sync issue, because everytime we sync from SmallRye, we lose this important piece of content:

| *group.id* | A unique string that identifies the consumer group the application belongs to. If not set, defaults to the application name as set by the `quarkus.application.name` configuration property. If that is not set either, a unique, generated id is used. It is recommended to always define a `group.id`, the automatic generation is only a convenient feature for development. Type: _string_ | false |

(We should actually update this to mention ${quarkus.uuid}, but first, we need to make sure we don't lose the text all the time.)

I tested a "not-so-ugly" way of doing this. But it involves generating optional includes in the original SmallRye RM documentation. @Ladicek what do you think?

I'm not sure if it needs to be includes, maybe just AsciiDoc conditionals (ifdef, ifndef) would be enough?

I don't think that neither include nor ifdef solves this issue. I don't think that we should add quarkus related content to the SmallRye RM repo.

I included the ${quarkus.uuid} to group.id property documentation.

Well we already have Quarkus-specific stuff in RM documentation, so I would be fine with including more, but your call :-)

I don't know I can hardly find any reference to Quarkus in RM repo. Maybe we can decide on this later?

Sure thing!

Ladicek · 2021-07-23T16:36:38Z

This looks OK to me. I didn't know we don't have the necessary infrastructure in place for @Startup probes. @xstefank could you please take a look at that? (Or who maintains the SmallRye Health extension in Quarkus?)

quarkus-bot · 2021-07-23T19:19:28Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f26cfb7`

Status	Name	Step	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Test failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✖	JVM Tests - JDK 16	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the Surefire reports. This report is incomplete.

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-reactive-panache

✖ io.quarkus.it.panache.reactive.PanacheFunctionalityTest.testPanacheFunctionality line 49 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/java.net.SocketInputStream.socketRead0(Native Method)
	at java.base/java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
	at java.base/java.net.SocketInputStream.read(SocketInputStream.java:168)
	at java.base/java.net.SocketInputStream.read(SocketInputStream.java:140)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:161)
	at org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:82)
	at org.apache.http.impl.io.AbstractSessionInputBuffer.readLine(AbstractSessionInputBuffer.java:276)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:138)
	at org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:56)
	at org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:259)
	at org.apache.http.impl.AbstractHttpClientConnection.receiveResponseHeade...

📦 integration-tests/kubernetes/quarkus-standard-way

✖ io.quarkus.it.kubernetes.KnativeWithHealthTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

✖ io.quarkus.it.kubernetes.KubernetesInitContainersTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

✖ io.quarkus.it.kubernetes.KubernetesWithHealthAndJibTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

✖ io.quarkus.it.kubernetes.KubernetesWithHealthTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

✖ io.quarkus.it.kubernetes.KubernetesWithRootAndHealthTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

✖ io.quarkus.it.kubernetes.OpenshiftWithHealthTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor#kubernetes threw an exception: java.lang.IllegalArgumentException: Build item class must be leaf (final) types: class io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem
	at io.quarkus.builder.item.BuildItem.<init>(BuildItem.java:22)
	at io.quarkus.builder.item.SimpleBuildItem.<init>(SimpleBuildItem.java:10)
	at io.quarkus.kubernetes.spi.KubernetesHealthStartupPathBuildItem.<init>(KubernetesHealthStartupPathBuildItem.java:9)
	at io.quarkus.smallrye.health.deployment.SmallRyeHealthProcessor.kubernetes(SmallRyeHealthProcessor.java:344)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.Delegating...

ozangunalp · 2021-07-28T14:18:46Z

@xstefank can you take a look at this for the @Startup probes I added ?

xstefank

Thanks, LGTM. It seems that I missed the stuff that Quarkus does on top of the spec integration when I was doing the update so thanks for this.

Ladicek · 2021-07-29T13:33:19Z

docs/src/main/asciidoc/smallrye-kafka-incoming.adoc

+
+It is recommended to always define a `group.id`, the automatic generation is only a convenient feature for development.
+
+Type: _string_ | false |


So originally, we had

| *group.id* | A unique string that identifies the consumer group the application belongs to. If not set, defaults to the application name as set by the `quarkus.application.name` configuration property. If that is not set either, a unique, generated id is used. It is recommended to always define a `group.id`, the automatic generation is only a convenient feature for development. Type: _string_ | false |

What we have now is a little hard to understand (the mention of automatic generation without previous explanation is strange, and the sentence about quarkus.uuid interrupts the reading flow IMHO).

I'd add the quarkus.uuid stuff at the end, resulting in something like:

| *group.id* | A unique string that identifies the consumer group the application belongs to. If not set, defaults to the application name as set by the `quarkus.application.name` configuration property. If that is not set either, a unique, generated id is used. It is recommended to always define a `group.id`, the automatic generation is only a convenient feature for development. You can explicitly ask for automatically generated unique id by setting this property to `${quarkus.uuid}`. Type: _string_ | false |

Ladicek · 2021-07-29T13:33:57Z

I wouldn't be nitpicking now, except I see this needs to be rebased anyway, so I thought it won't hurt :-)

ozangunalp · 2021-07-29T13:41:47Z

I know, I was waiting for your final word :)

Wire startup probe

…cumentation Update health check doc for readiness and startup Add record key propagation.

Ladicek · 2021-07-29T13:52:38Z

OK :-) Sorry it took me so long!

ozangunalp requested a review from Ladicek July 23, 2021 15:26

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/health area/kubernetes area/reactive-messaging area/smallrye labels Jul 23, 2021

Ladicek reviewed Jul 23, 2021

View reviewed changes

ozangunalp force-pushed the startup_probe_smallrye_rm_3.8.0 branch from f26cfb7 to f840d17 Compare July 26, 2021 12:33

xstefank approved these changes Jul 29, 2021

View reviewed changes

Ladicek reviewed Jul 29, 2021

View reviewed changes

ozangunalp added 2 commits July 29, 2021 14:44

Upgrade Smallrye Reactive Messaging to 3.8.0

5cb6a08

Wire startup probe

Upgrade Smallrye Reactive Messaging to 3.8.0, Update configuration do…

bbe8e4e

…cumentation Update health check doc for readiness and startup Add record key propagation.

ozangunalp force-pushed the startup_probe_smallrye_rm_3.8.0 branch from f840d17 to bbe8e4e Compare July 29, 2021 13:45

Ladicek approved these changes Jul 29, 2021

View reviewed changes

Ladicek merged commit 7d55cc7 into quarkusio:main Jul 30, 2021

quarkus-bot bot added this to the 2.2 - main milestone Jul 30, 2021

manusa mentioned this pull request Jul 6, 2022

QuarkusHealthCheckEnricher : Add /q/health/started as startup probe if enabled eclipse-jkube/jkube#1468

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Smallrye Reactive Messaging to 3.8.0 #18972

Upgrade Smallrye Reactive Messaging to 3.8.0 #18972

ozangunalp commented Jul 23, 2021

Ladicek Jul 23, 2021

ozangunalp Jul 26, 2021

Ladicek Jul 26, 2021

ozangunalp Jul 26, 2021

ozangunalp Jul 26, 2021

Ladicek Jul 26, 2021

ozangunalp Jul 28, 2021

Ladicek Jul 28, 2021

Ladicek commented Jul 23, 2021

quarkus-bot bot commented Jul 23, 2021 •

edited

Failing Jobs - Building `f26cfb7`

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-reactive-panache

📦 integration-tests/kubernetes/quarkus-standard-way

ozangunalp commented Jul 28, 2021

xstefank left a comment

Ladicek Jul 29, 2021

Ladicek commented Jul 29, 2021

ozangunalp commented Jul 29, 2021

Ladicek commented Jul 29, 2021


		\| group.id \| A unique string that identifies the consumer group the application belongs to. If not set, a unique, generated id is used

		Type: _string_ \| false \|


		It is recommended to always define a `group.id`, the automatic generation is only a convenient feature for development.

		Type: _string_ \| false \|

Upgrade Smallrye Reactive Messaging to 3.8.0 #18972

Upgrade Smallrye Reactive Messaging to 3.8.0 #18972

Conversation

ozangunalp commented Jul 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ladicek commented Jul 23, 2021

quarkus-bot bot commented Jul 23, 2021 • edited

Failing Jobs - Building f26cfb7

Test Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/hibernate-reactive-panache

📦 integration-tests/kubernetes/quarkus-standard-way

ozangunalp commented Jul 28, 2021

xstefank left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ladicek commented Jul 29, 2021

ozangunalp commented Jul 29, 2021

Ladicek commented Jul 29, 2021

quarkus-bot bot commented Jul 23, 2021 •

edited

Failing Jobs - Building `f26cfb7`