Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hibernate ORM teardown needs to happen before the datasources are destroyed #1916

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Hibernate ORM teardown needs to happen before the datasources are destroyed #1916

merged 1 commit into from
Apr 8, 2019

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Apr 8, 2019 •
edited by gsmet
Loading

Fixes #1915

@Sanne Sanne requested a review from mkouba April 8, 2019 13:47
@mkouba
Copy link
Contributor

mkouba commented Apr 8, 2019

[ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.8.1:validate (default) on project quarkus-hibernate-orm: File '/home/vsts/work/1/s/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/JPAConfig.java' has not been previously formatted. Please format file and commit before running validation!

@Sanne Sanne merged commit 25e136a into quarkusio:master Apr 8, 2019
@Sanne Sanne deleted the ShutdownOrder branch April 8, 2019 21:23
@gsmet gsmet added this to the 0.13.1 milestone Apr 9, 2019
@gsmet gsmet changed the title Hibernate ORM teardown needs to happen before the datasources are des… Hibernate ORM teardown needs to happen before the datasources are destroyed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sanne @mkouba @gsmet