-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last-updated metadata attribute to the PlatformCatalog as reported by Maven metadata #19419
Add last-updated metadata attribute to the PlatformCatalog as reported by Maven metadata #19419
Conversation
…d by Maven metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building fa026cb
Full information is available in the Build summary check run. Test Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖
|
@@ -161,7 +161,7 @@ public RegistryClient buildRegistryClient(RegistryConfig config) throws Registry | |||
} | |||
|
|||
return new RegistryClientDispatcher(config, platformsResolver, | |||
Boolean.TRUE.equals(config.getPlatforms().getExtensionCatalogsIncluded()) | |||
Boolean.TRUE.equals(platformsConfig == null ? Boolean.FALSE : platformsConfig.getExtensionCatalogsIncluded()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean.TRUE.equals(platformsConfig == null ? Boolean.FALSE : platformsConfig.getExtensionCatalogsIncluded()) | |
(platformsConfig != null && platformsConfig.getExtensionCatalogsIncluded()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will result in an NPE when `platformsConfig.getExtensionCatalogsIncluded() returns null.
This change adds
last-updated
attribute to the PlatformCatalog metadata containing the timestamp at which the catalog was last updated.