Filter out duplicate JMX registration message #19440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to register a producer/consumer/admin with an already used id. This is done in the Kafka connector extension as it's likely going to happen with the connector which use the channel name as id. When using the bare Kafka client, the user must set the id. The filter is only applied in dev and test modes.
|
I have a question: if hidden in test or dev mode, won't the developer have a bad surprise when pushing to production. |
|
It shouldn't, but I wanted to keep "prod" just in case. However, we can hide it everywhere. For the context, the objects are registered in JMX, and when using the continuous tests, two applications run concurrently, leading to the double registration. |
gsmet
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out duplicate registration messages when the Kafka client tries to register a producer/consumer/admin with an already used id. This is done in the Kafka connector extension as it's likely going to happen with the connector which use the channel name as id. When using the bare Kafka client, the user must set the id. The filter is only applied in dev and test modes.
Fix #19045.