Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1944, make sure file path is decoded #1945

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Fixes #1944, make sure file path is decoded #1945

merged 1 commit into from
Apr 9, 2019

Conversation

stuartwdouglas
Copy link
Member

No description provided.

@gsmet
Copy link
Member

gsmet commented Apr 9, 2019

@dmlloyd I know you love URL and paths, could you check this one?

dmlloyd
dmlloyd approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be arguably cleaner to do new File(url.toUri()) or new File(url.toUri().getPath()), but this is fine too.

@gsmet gsmet added this to the 0.13.1 milestone Apr 9, 2019
@gsmet
Copy link
Member

gsmet commented Apr 9, 2019

Merging for 0.13.1, we can improve later.

@gsmet gsmet merged commit a79f4c9 into quarkusio:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuartwdouglas @gsmet @dmlloyd