Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper config values when pulling base image for native build using Jib #19780

Merged
merged 1 commit into from Aug 30, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Aug 30, 2021

This was already correctly done for the other artifact types.

Fixes: #19744

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2021
@geoand geoand merged commit 0f7986e into quarkusio:main Aug 30, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Aug 30, 2021
@geoand geoand deleted the #19744 branch August 30, 2021 14:51
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 30, 2021
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.1.Final Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jib native build failures when setting custom 'quarkus.jib.base-native-image' values
3 participants