New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support testing for multi module projects #19793
Conversation
949124b
to
2b61da5
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2b61da5
Failures⚙️ JVM Tests - JDK 16 #- Failing: devtools/gradle
📦 devtools/gradle✖ |
I gave this a try and it does execute a test from an upstream module, but it fails with an
The reproducer is here: https://github.com/famod/modmono-quarkus/tree/cont-testing-multi
PS: Please ignore the |
This needs some more work, I need to properly resolve an AppModel for each module. I am not sure how practical this will be with the current codebase, it may need to be delayed until after the planned refactoring work. |
@stuartwdouglas Sorry for the delay, but now I finally had a little time to try it out. Testing was exploratory. Observations
Issues
Hope this input will help, and I hope you will find time to work on it again after the refactoring work. We still find the feature very valuable. |
So issue 1) is the one that I mentioned was a known problem. It might still be worth merging this with it as a documented limitation, possibly with this disabled by default until it is resolved.
|
BTW for point 2 I think if you add |
2b61da5
to
52ce012
Compare
I have added a note about the limitation and changed this so it is not longer the default, however I think it is still worth including. |
This workflow status is outdated as a new workflow run has been triggered. |
68cebbb
to
529a1be
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 529a1be
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: docs integration-tests/kubernetes/quarkus-standard-way-kafka integration-tests/reactive-messaging-kafka and 1 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/amazon-lambda/deployment
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more 📦 extensions/amazon-lambda/deployment✖
⚙️ JVM Tests - JDK 16 #- Failing: extensions/hibernate-orm/deployment
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 82 more 📦 extensions/hibernate-orm/deployment✖
⚙️ Maven Tests - JDK 11 #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
⚙️ Maven Tests - JDK 11 Windows #- Failing: integration-tests/maven
📦 integration-tests/maven✖
✖
|
Tried this but same result, i.e. it does not get picked up.
|
529a1be
to
5892854
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5892854
Failures⚙️ Initial JDK 11 Build #- Failing: test-framework/maven
! Skipped: integration-tests/container-image/maven-invoker-way integration-tests/kotlin integration-tests/kubernetes/maven-invoker-way and 2 more 📦 test-framework/maven✖ |
0f98ef8
to
78c0223
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 78c0223
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
|
78c0223
to
8657eb4
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 8657eb4
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
This should be ready to merge |
⬆️ still fails, I'm afraid... |
8657eb4
to
3523830
Compare
@famod oops, looks like something got missed in a rebase, should be fixed now. |
@stuartwdouglas I'm now getting the same results, regardless of PS: It always includes the test from that other module ( |
...but on the plus side there is no exception anymore! 👍 |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3523830
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/hibernate-orm/deployment
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 84 more 📦 extensions/hibernate-orm/deployment✖
|
Note that continuous testing supports multi-module projects, so tests in modules other than the application can still | ||
be run when files are changed. The modules that are run can be controlled using config as listed below. | ||
|
||
This is enabled by default, and can be disabled via `quarkus.test.only-test-application-module=false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is enabled by default, and can be disabled via `quarkus.test.only-test-application-module=false`. | |
This is enabled by default, and can be disabled via `quarkus.test.only-test-application-module=true`. |
❔
My bad, I got confused, partially by the changed docs (see #19793 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played with it a little, looking good! Can't comment much on the code though, looks like you had to extract/restructure things for the new runner, right?
So LGTM, just that documented property seems inverted.
Just in case, I tried this change on top of my bootstrap refactoring branch. The Gradle Kotlin test has passed (I guess it may pass in main on the re-run too) but the import sql one failed as well with
|
5da5ee3
to
9d62307
Compare
Continuous testing will now run tests from all modules, with the option to configure the old behaviour. Fixes quarkusio#19362
9d62307
to
7e804f1
Compare
Hopefully all good now. |
Failing Jobs - Building 7e804f1
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/grpc/deployment
! Skipped: docs integration-tests/devmode integration-tests/grpc-health and 9 more 📦 extensions/grpc/deployment✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also retested it with my small sample project.
Don't know about that one test failure, looks unrelated.
The mvn part in the other job was actually successful but then the run timed out.
@stuartwdouglas do you want this to be backported to 2.3? It's too late for the 2.3.0.Final though. |
This is too big a change, let's just leave it for now.
…On Thu, 30 Sep 2021, 12:11 am Alexey Loubyansky, ***@***.***> wrote:
@stuartwdouglas <https://github.com/stuartwdouglas> do you want this to
be backported to 2.3? It's too late for the 2.3.0.Final though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19793 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQG6YJWTKWWYTCO2OO573UEMM67ANCNFSM5DDOFV7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Continuous testing will now run tests from all modules, with the option
to configure the old behaviour.