Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with skip predicates in scheduled methods #19904

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 3, 2021

Before this fix, the implementations where actually
eligible for bean removal

Fixes: #19900

Before this fix, the implementations where actually
eligible for bean removal

Fixes: quarkusio#19900
@mkouba
Copy link
Contributor

mkouba commented Sep 3, 2021

Ah, it's the observer that made the io.quarkus.scheduler.test.ConditionalExecutionTest.IsDisabled unremovable. Good catch!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 3, 2021
@geoand
Copy link
Contributor Author

geoand commented Sep 3, 2021

Yup, had me baffled for a while :)

@geoand geoand merged commit 4e5ce8a into quarkusio:main Sep 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 3, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 3, 2021
@geoand geoand deleted the #19900 branch September 3, 2021 14:01
@gsmet gsmet modified the milestones: 2.3 - main, 2.2.2.Final Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There must be exactly one bean that matches the skip predicate
3 participants