REST Client Reactive: support POJO as non-file fields in multipart messages #20127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Sep 14, 2021
| /** | ||
| * based on {@link io.vertx.ext.web.client.impl.MultipartFormUpload} | ||
| */ | ||
| public class QuarkusMultipartFormUpload implements ReadStream<Buffer> { |
There was a problem hiding this comment.
I sure hope this is a straight copy of io.vertx.ext.web.client.impl.MultipartFormUpload, otherwise it will be impossible to vouch for :)
There was a problem hiding this comment.
|
My only real question is whether all the codepaths are tested |
|
The integration test we had tested all the cases but passing a POJO. |
michalszynkiewicz
force-pushed
the
multipart-pojo-fields
branch
from
106b744
to
3ace402
Compare
|
done |
geoand
approved these changes
Sep 14, 2021
|
Do you plan a backport to 2.2? If not, for what reason? @geoand @michalszynkiewicz |
|
Not really as it could introduce regressions we don't want in patch releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19892