Make @TestProfile work with integration tests #20223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing Jobs - Building 3221e8e
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
famod
reviewed
Sep 17, 2021
| import io.quarkus.test.junit.QuarkusTestProfile; | ||
|
|
||
| // we use a QuarkusTestProfile to ensure that QuarkusIntegrationTest works properly with them | ||
| public class AppTestProfile implements QuarkusTestProfile { |
There was a problem hiding this comment.
Shouldn't that be in integration-tests/main? What if narayana-lra is moved out of the Quarkus main repo at some point? Wouldn't we then loose coverage of this feature?
There was a problem hiding this comment.
Indeed, but we can cross that bridge if we get to it :)
There was a problem hiding this comment.
😄
My point is: Will anyone remember to look that closely? Anyway, I just find it confusing that coverage of some test framework aspects is scattered over the repo which makes it hard to validate changes without running full CI.
famod
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20205