Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hibernate ORM: do not log stats when statistics collection is enabled #20693

Merged
merged 1 commit into from Oct 12, 2021
Merged

Hibernate ORM: do not log stats when statistics collection is enabled #20693

merged 1 commit into from Oct 12, 2021

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Oct 12, 2021

Fixes #20666

@Sanne Sanne requested a review from jmartisk October 12, 2021 11:44
@Sanne Sanne merged commit 64ffed5 into quarkusio:main Oct 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 12, 2021
@Sanne Sanne deleted the NoStatsLogged branch October 12, 2021 13:07
@aloubyansky aloubyansky modified the milestones: 2.5 - main, 2.4.0.Final Oct 18, 2021
@gsmet gsmet modified the milestones: 2.4.0.Final, 2.3.1.Final Oct 18, 2021
@jmartisk jmartisk mentioned this pull request Nov 4, 2021
Closed
@gsmet
Copy link
Member

gsmet commented Nov 30, 2021

@Sanne @tqvarnst @rsvoboda I'm not sure we want to backport this one given some users complained about the new behavior and we had follow ups commits (#21194).

I would rather be conservative and not include it in 2.2.

@Sanne
Copy link
Member Author

Sanne commented Nov 30, 2021

@gsmet agreed.

@rsvoboda
Copy link
Member

rsvoboda commented Dec 1, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartisk jmartisk jmartisk approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/persistence kind/enhancement New feature or request
Projects
None yet
Milestone
2.3.1.Final
Development

Successfully merging this pull request may close these issues.

quarkus.hibernate-orm.statistics can not be set to false if metrics.enabled is true
5 participants
@Sanne @gsmet @rsvoboda @jmartisk @aloubyansky