Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda maven archtetypes, startup bugs, and docs #20747

Merged
merged 1 commit into from Oct 13, 2021

Conversation

patriot1burke
Copy link
Contributor

@patriot1burke patriot1burke commented Oct 13, 2021

The live coding/testing merge a few weeks ago broke the maven archtetypes and introduced some startup bugs. Specifically, the poll loop would start before Quarkus had fully initiliazed and would process a request before quarkus was fully started and initialized.

Fixes #20745
Fixes #20689
Fixes #20674
Fixes #20665
Fixes #20633

fix deprecated refernce

lambda doc fix
@patriot1burke
Copy link
Contributor Author

@gsmet This needs to backport to 2.3 branch.

@geoand
Copy link
Contributor

geoand commented Oct 13, 2021

@patriot1burke I am currently handling the backports for the 2.3 release.

I have one question: Does this PR fix all the issues you mention? If so, then please replace See with Fixes so GH can close the issues when we merge the PR

@patriot1burke
Copy link
Contributor Author

@patriot1burke I am currently handling the backports for the 2.3 release.

I have one question: Does this PR fix all the issues you mention? If so, then please replace See with Fixes so GH can close the issues when we merge the PR

s/See/Fixes/g done. Ty for quick response.

@geoand
Copy link
Contributor

geoand commented Oct 13, 2021

Great, thanks a lot!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 13, 2021
@patriot1burke patriot1burke merged commit 73122d8 into quarkusio:main Oct 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 13, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 13, 2021
@aloubyansky aloubyansky modified the milestones: 2.5 - main, 2.4.0.Final Oct 18, 2021
@gsmet gsmet modified the milestones: 2.4.0.Final, 2.3.1.Final Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment