Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getParameterTypes().length with getParameterCount() #21750

Conversation

clara0
Copy link
Contributor

@clara0 clara0 commented Nov 27, 2021

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 27, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with ellipsis (make sure the title is complete)

This message is automatically generated by a bot.

@clara0 clara0 force-pushed the replace-getParameterTypes-length-getParameterCount branch from fc3a318 to 1ceebca Compare November 27, 2021 02:18
@clara0 clara0 changed the title QUARKUS-1476 Replace usages of getParameterTypes().length with getPar… QUARKUS-1476 Replace getParameterTypes().length with getParameterCount() Nov 27, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@gsmet gsmet changed the title QUARKUS-1476 Replace getParameterTypes().length with getParameterCount() Replace getParameterTypes().length with getParameterCount() Nov 27, 2021
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 27, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 27, 2021

Failing Jobs - Building 1ceebca

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-reactive-messaging-kafka/deployment 
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 2 more

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario1 - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed

@geoand geoand merged commit d47f075 into quarkusio:main Nov 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 29, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants