Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constructor injection in Kotlin Panache repositories #22015

Merged
merged 1 commit into from Dec 8, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 8, 2021

Fixes: #22014

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should the same works for Hibernate with Panache ?
Can you add a test there ?

@geoand
Copy link
Contributor Author

geoand commented Dec 8, 2021

It does work, the problem was Kotlin specific, but I'll add a test anyway - good idea

@loicmathieu
Copy link
Contributor

@geoand yeah, I mean Hibernate with Panache in Kotlin ;)

@geoand
Copy link
Contributor Author

geoand commented Dec 8, 2021

👍🏼

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 8, 2021
@gsmet gsmet merged commit e9d6982 into quarkusio:main Dec 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 8, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 8, 2021
@imalik8088
Copy link

wow super fast fix, thank you very much for your time and great work!

@geoand
Copy link
Contributor Author

geoand commented Dec 9, 2021

YW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointer by using PanacheMongoRepository with a dependency in the contructor in Kotlin
4 participants