Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject illegal placeholder in Maven CI friendly version property #22131

Merged
merged 1 commit into from Dec 13, 2021
Merged

Reject illegal placeholder in Maven CI friendly version property #22131

merged 1 commit into from Dec 13, 2021

Conversation

famod
Copy link
Member

@famod famod commented Dec 13, 2021

Results in a more useful error message than:

java.lang.IllegalArgumentException: named capturing group is missing trailing '}'

e.g. (from the test):

java.lang.IllegalArgumentException: Illegal placeholder in Maven CI friendly version property "revision": ${main.project.version}
	Please consult https://maven.apache.org/maven-ci-friendly.html#single-project-setup

Came up more than once, last time I noticed was here: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/BootstrapMavenException.20when.20using.20.24.7Brevision.7D

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Dec 13, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 13, 2021

Failing Jobs - Building fd40b5f

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs

@gsmet gsmet merged commit f65d72f into quarkusio:main Dec 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 13, 2021
@famod famod deleted the maven-ci-friendly-illegal-placeholder branch December 13, 2021 19:47
@famod
Copy link
Member Author

famod commented Dec 13, 2021

@gsmet did you decide to not backport it in the end? Asking also because of #22171 which was just created.

@famod
Copy link
Member Author

famod commented Dec 14, 2021

FTR, this PR also covers what has been reported in #22171 (No group with name {version}).

@gsmet
Copy link
Member

gsmet commented Dec 14, 2021

It didn't look very critical to backport but yeah, we can do it.

@gsmet gsmet modified the milestones: 2.7 - main, 2.6.0.Final Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants