Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute - do not split expr parts before the literal is parsed #22274

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Qute - do not split expr parts before the literal is parsed #22274

merged 1 commit into from
Dec 16, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 16, 2021

No description provided.

@mkouba mkouba requested a review from gastaldi December 16, 2021 08:35
@mkouba mkouba added this to the 2.7 - main milestone Dec 16, 2021
FroMage
FroMage approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, is this really only in if sections? Do we also have byte/short/... Literals ?

@FroMage
Copy link
Member

FroMage commented Dec 16, 2021

Also, are literals documented ?

@mkouba
Copy link
Contributor Author

mkouba commented Dec 16, 2021

Also, are literals documented ?

https://quarkus.io/guides/qute-reference#literals

@mkouba
Copy link
Contributor Author

mkouba commented Dec 16, 2021

Well, is this really only in if sections?

No. You can use literals anywhere. But you can't use e.g. negative numbers as a standalone expression {-1.0f} because - is not a valid tag start.

Do we also have byte/short/... Literals ?

No. There was no use case so far.

@mkouba mkouba merged commit 3ca1d7e into quarkusio:main Dec 16, 2021
@FroMage
Copy link
Member

FroMage commented Dec 20, 2021

Thanks!

@gsmet gsmet modified the milestones: 2.7 - main, 2.6.1.Final Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.1.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkouba @FroMage @gastaldi @gsmet