Warn when Resource method returns JSON but no JSON provider exists #22980

geoand · 2022-01-18T15:53:54Z

Resolves: #22970

gsmet

Spotted a small typo.

Don't we need the same for the client?

...c/main/java/io/quarkus/resteasy/reactive/server/deployment/QuarkusServerEndpointIndexer.java

geoand · 2022-01-18T16:04:39Z

Don't we need the same for the client?

Yeah, but that might need some extra changes that I'd rather not do now.

issue addressed

gsmet · 2022-01-18T17:35:25Z

CI is not happy about this:

Error: ]: Build step io.quarkus.resteasy.reactive.server.deployment.ResteasyReactiveProcessor#setupEndpoints threw an exception: java.lang.RuntimeException: java.lang.RuntimeException: Failed to process method 'io.quarkus.resteasy.reactive.server.test.customproviders.UniFiltersResource#filters'
	at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:278)
	at io.quarkus.resteasy.reactive.server.deployment.ResteasyReactiveProcessor.setupEndpoints(ResteasyReactiveProcessor.java:525)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:882)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at java.base/java.lang.Thread.run(Thread.java:829)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)
Caused by: java.lang.RuntimeException: Failed to process method 'io.quarkus.resteasy.reactive.server.test.customproviders.UniFiltersResource#filters'
	at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createResourceMethod(EndpointIndexer.java:639)
	at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:366)
	at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createEndpoints(EndpointIndexer.java:249)
	... 12 more
Caused by: java.lang.NullPointerException
	at io.quarkus.resteasy.reactive.common.deployment.JsonDefaultProducersHandler.handle(JsonDefaultProducersHandler.java:26)
	at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.isDefaultJson(QuarkusServerEndpointIndexer.java:171)
	at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.warnAboutMissingJsonProviderIfNeeded(QuarkusServerEndpointIndexer.java:163)
	at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.handleAdditionalMethodProcessing(QuarkusServerEndpointIndexer.java:156)
	at io.quarkus.resteasy.reactive.server.deployment.QuarkusServerEndpointIndexer.handleAdditionalMethodProcessing(QuarkusServerEndpointIndexer.java:32)
	at org.jboss.resteasy.reactive.common.processor.EndpointIndexer.createResourceMethod(EndpointIndexer.java:631)
	... 14 more

	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:613)

quarkus-bot · 2022-01-18T17:42:06Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `9727a53`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Data3	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Security2	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment 
! Skipped: extensions/apicurio-registry-avro/deployment extensions/avro/deployment extensions/hibernate-reactive/deployment and 74 more

📦 extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment

✖ io.quarkus.resteasy.reactive.server.test.beanparam.CustomConverterInBeanParamTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customexceptions.CustomExceptionMappersTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customexceptions.GlobalThrowableExceptionMapperTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customexceptions.PerClassThrowableExceptionMapperTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customproviders.AbortingFiltersTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customproviders.CustomFiltersTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.customproviders.UniFiltersTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.InvalidEncodingTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.LargerThanDefaultFormAttributeMultipartFormInputTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartFormInputDevModeTest.test - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartInputBodyHandlerTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartInputTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartInputWithAllUploadsTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartOptionalInputTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.MultipartOutputUsingBlockingEndpointsTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.multipart.TooLargeFormAttributeMultipartFormInputTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.BasicGenericTypesHandlingTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.CollectionDefaultValueTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.InheritanceTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.MatchedResourceTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.MultiInterfaceResLocatorTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.MultipleAcceptHeaderTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.resource.basic.SpecialResourceTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.simple.InterfaceWithImplTest. - More details - Source on GitHub

✖ io.quarkus.resteasy.reactive.server.test.stream.StreamTestCase. - More details - Source on GitHub

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment 
! Skipped: extensions/apicurio-registry-avro/deployment extensions/avro/deployment extensions/hibernate-reactive/deployment and 73 more