Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the output of list extensions #22995

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Update the output of list extensions #22995

merged 1 commit into from
Jan 19, 2022

Conversation

ebullient
Copy link
Contributor

@ebullient ebullient commented Jan 19, 2022

Resolves #18062
Resolves #22812

Human feedback needed (use quarkus list ext inside and outside a project with no arguments, with --id, --concise, --full or --origin).

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 19, 2022
Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I still think the many exclusive options is too much over just having a way to toggle on/off various fields but that's a future thing. This PR improves over what is there now and most importantly unifies how we report platform and origins.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2d759b2

Status Name Step Failures Logs Raw logs
Devtools Tests - JDK 11 Build Failures Logs Raw logs
Devtools Tests - JDK 11 Windows Build Failures Logs Raw logs
Devtools Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.commands.ListExtensionsTest.listWithoutBom line 100 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Agroal should list as being default: ✬ quarkus-agroal                                     Agroal - Database connection pool                            999-SNAPSHOT              https://quarkus.io/guides/datasource ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)

⚙️ Devtools Tests - JDK 11 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.commands.ListExtensionsTest.listWithoutBom line 100 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Agroal should list as being default: ✬ quarkus-agroal                                     Agroal - Database connection pool                            999-SNAPSHOT              https://quarkus.io/guides/datasource ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.commands.ListExtensionsTest.listWithoutBom line 100 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Agroal should list as being default: ✬ quarkus-agroal                                     Agroal - Database connection pool                            999-SNAPSHOT              https://quarkus.io/guides/datasource ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)

@ebullient ebullient added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 19, 2022

Failing Jobs - Building a5cfc87

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet gsmet merged commit 270edc6 into quarkusio:main Jan 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 19, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 19, 2022
@ebullient ebullient deleted the list-ext branch January 19, 2022 19:23
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 21, 2022
rsvoboda added a commit to rsvoboda/quarkus-test-framework that referenced this pull request Jan 26, 2022
fedinskiy pushed a commit to quarkus-qe/quarkus-test-framework that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update cli to have platform marker in extension list CLI: Extensions list enhancements
3 participants