Adjustments for the info and update commands #22999

aloubyansky · 2022-01-19T09:20:19Z

Adjustments following feedback on #22979

Add 'experimental' warning to the info and update commands
use a single instance of the catalog resolver for the update (fixes Looking for the newly published extensions in registry.quarkus.io logged twice)
make sure update to the current platform version isn't suggested (e.g Update: io.quarkus.platform:quarkus-bom:pom:2.6.2.Final -> 2.6.2.Final)

aloubyansky · 2022-01-19T09:23:46Z

About Instead of "Recommended Quarkus platform BOM updates" should we write "To follow latest recommended Quarkus platform:" ?
I see what you mean "to follow... do this" but I am not yet sure it's better. We probably need to have a good discussion on the whole presentation part, given that we all agree the phrasing and formatting isn't easy to follow.

quarkus-bot · 2022-01-19T14:09:25Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `306e21a`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

gsmet · 2022-01-19T14:27:45Z

@aloubyansky were you able to improve a bit the ordering of things to update?

aloubyansky · 2022-01-19T15:08:55Z

No, I haven't yet. I can look into that and add it to this change.

aloubyansky · 2022-01-19T16:51:04Z

Fixed the ordering.

...ools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusInfo.java

quarkus-bot · 2022-01-20T11:36:07Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `b6bf2f6`

Status	Name	Failures	Logs	Raw logs
⌛	Initial JDK 11 Build	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	⚠️ Check →	Logs	Raw logs

quarkus-bot · 2022-01-20T16:09:24Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `b00e8a7`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 22 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.gradle.devmode.MultiModuleNamedInjectionDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

aloubyansky · 2022-01-20T16:23:01Z

Added update instructions for extensions that are moved in to/out of the platform between releases.

quarkus-bot · 2022-01-20T16:32:19Z

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

Failing Jobs - Building `86ae1e2`

Status	Name	Failures	Logs	Raw logs
⌛	Initial JDK 11 Build	⚠️ Check →	Logs	Raw logs
⌛	Attach pull request number	⚠️ Check →	Logs	Raw logs
⌛	CI Sanity Check	⚠️ Check →	Logs	Raw logs

maxandersen · 2022-01-21T11:50:03Z

...ools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusInfo.java

@@ -34,6 +34,9 @@ public QuarkusInfo() {

    @TaskAction
    public void logInfo() {
+
+        getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");


Suggested change

getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");

getProject().getLogger().warn("quarkus info is experimental, its options and output might change in future versions");

In maven output this comes possibly many many lines away from what you just executed thus better to be explicit.

maxandersen · 2022-01-21T11:50:29Z

...ls/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusUpdate.java

@@ -55,6 +55,9 @@ public QuarkusUpdate() {

    @TaskAction
    public void logUpdates() {
+
+        getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");


Suggested change

getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");

getProject().getLogger().warn("quarkus update is experimental, its options and output might change in future versions");

maxandersen · 2022-01-21T11:50:58Z

devtools/maven/src/main/java/io/quarkus/maven/InfoMojo.java

@@ -20,6 +20,12 @@
 @Mojo(name = "info", requiresProject = true)
 public class InfoMojo extends QuarkusProjectStateMojoBase {

+    @Override
+    protected void validateParameters() throws MojoExecutionException {
+        getLog().warn("This task is experimental, its options and output might change in future versions");


Suggested change

getLog().warn("This task is experimental, its options and output might change in future versions");

getLog().warn("quarkus info is experimental, its options and output might change in future versions");

maxandersen · 2022-01-21T11:58:39Z

Looks good - added just comment to be explicit.

A few quirks I found.

mvn running update on a newly created project it prints:

[INFO] Recommended Quarkus platform BOM updates:

nothing else - maybe have a "Project extensions are aligned with the platform. No recommendations found." instead?

On how to word it, I'm wondering if just write about aligned with platform vs non-aligned with platform when it comes to version differences.?

maxandersen

looks good just be more explicit to the user.

…ngle instance of the catalog resolver for the update, make sure update to the current platform version isn't suggested

aloubyansky · 2022-01-21T16:28:47Z

All fixed.

maxandersen

lgtm

aloubyansky requested a review from maxandersen January 19, 2022 09:20

aloubyansky added the triage/backport? label Jan 19, 2022

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 19, 2022

aloubyansky mentioned this pull request Jan 19, 2022

Support for assisted project updates #22979

Merged

aloubyansky force-pushed the quarkus-info branch from 306e21a to 1a8c6bc Compare January 19, 2022 16:50

gsmet reviewed Jan 20, 2022

View reviewed changes

...ools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusInfo.java Outdated Show resolved Hide resolved

aloubyansky force-pushed the quarkus-info branch from 1a8c6bc to b6bf2f6 Compare January 20, 2022 11:29

quarkus-bot bot added area/documentation area/mongodb labels Jan 20, 2022

aloubyansky force-pushed the quarkus-info branch from b6bf2f6 to b00e8a7 Compare January 20, 2022 11:30

aloubyansky force-pushed the quarkus-info branch from b00e8a7 to 86ae1e2 Compare January 20, 2022 16:22

aloubyansky force-pushed the quarkus-info branch from 86ae1e2 to 36d9b43 Compare January 20, 2022 16:26

maxandersen reviewed Jan 21, 2022

View reviewed changes

maxandersen requested changes Jan 21, 2022

View reviewed changes

Adds 'experimental' warning to the info and update commands, use a si…

3835da7

…ngle instance of the catalog resolver for the update, make sure update to the current platform version isn't suggested

aloubyansky force-pushed the quarkus-info branch from 36d9b43 to 3835da7 Compare January 21, 2022 16:28

maxandersen approved these changes Jan 21, 2022

View reviewed changes

aloubyansky merged commit 53e5033 into quarkusio:main Jan 21, 2022

quarkus-bot bot added this to the 2.8 - main milestone Jan 21, 2022

gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 24, 2022

gsmet removed the triage/backport? label Jan 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adjustments for the info and update commands #22999

Adjustments for the info and update commands #22999

aloubyansky commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

quarkus-bot bot commented Jan 19, 2022 •

edited

Failing Jobs - Building `306e21a`

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

gsmet commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `b6bf2f6`

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `b00e8a7`

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

aloubyansky commented Jan 20, 2022

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `86ae1e2`

maxandersen Jan 21, 2022

maxandersen Jan 21, 2022

maxandersen Jan 21, 2022

maxandersen commented Jan 21, 2022

maxandersen left a comment

aloubyansky commented Jan 21, 2022

maxandersen left a comment

	getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");
	getProject().getLogger().warn("quarkus info is experimental, its options and output might change in future versions");

	getProject().getLogger().warn("This task is experimental, its options and output might change in future versions");
	getProject().getLogger().warn("quarkus update is experimental, its options and output might change in future versions");

	getLog().warn("This task is experimental, its options and output might change in future versions");
	getLog().warn("quarkus info is experimental, its options and output might change in future versions");

Adjustments for the info and update commands #22999

Adjustments for the info and update commands #22999

Conversation

aloubyansky commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

quarkus-bot bot commented Jan 19, 2022 • edited

Failing Jobs - Building 306e21a

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

gsmet commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

aloubyansky commented Jan 19, 2022

quarkus-bot bot commented Jan 20, 2022 • edited

Failing Jobs - Building b6bf2f6

quarkus-bot bot commented Jan 20, 2022 • edited

Failing Jobs - Building b00e8a7

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

aloubyansky commented Jan 20, 2022

quarkus-bot bot commented Jan 20, 2022 • edited

Failing Jobs - Building 86ae1e2

maxandersen Jan 21, 2022

Choose a reason for hiding this comment

maxandersen Jan 21, 2022

Choose a reason for hiding this comment

maxandersen Jan 21, 2022

Choose a reason for hiding this comment

maxandersen commented Jan 21, 2022

maxandersen left a comment

Choose a reason for hiding this comment

aloubyansky commented Jan 21, 2022

maxandersen left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jan 19, 2022 •

edited

Failing Jobs - Building `306e21a`

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `b6bf2f6`

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `b00e8a7`

quarkus-bot bot commented Jan 20, 2022 •

edited

Failing Jobs - Building `86ae1e2`