Add note about mocking @Singleton beans #23000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Jan 19, 2022
| @@ -944,6 +944,11 @@ public class MockGreetingServiceTest { | |||
| ---- | |||
| <1> Since we configured `greetingService` as a mock, the `GreetingResource` which uses the `GreetingService` bean, we get the mocked response instead of the response of the regular `GreetingService` bean | |||
|
|
|||
| [NOTE] | |||
| By default the `@InjectMock` annotation can be used for any normal CDI scoped bean (e.g. `@ApplicationScoped`, `@RequestScoped`). | |||
| Mocking `@Singleton` beans can be done by setting the `convertScopes` property to true (such as `@InjectMock(convertScopes = true`). | |||
There was a problem hiding this comment.
Suggested change
| Mocking `@Singleton` beans can be done by setting the `convertScopes` property to true (such as `@InjectMock(convertScopes = true`). | |
| Mocking `@Singleton` beans can be performed by setting the `convertScopes` property to true (such as `@InjectMock(convertScopes = true`). |
geoand
reviewed
Jan 19, 2022
| [NOTE] | ||
| By default the `@InjectMock` annotation can be used for any normal CDI scoped bean (e.g. `@ApplicationScoped`, `@RequestScoped`). | ||
| Mocking `@Singleton` beans can be done by setting the `convertScopes` property to true (such as `@InjectMock(convertScopes = true`). | ||
| This will convert the `@Singleton` bean to an `@ApplicationScoped` bean for the test. |
There was a problem hiding this comment.
Suggested change
| This will convert the `@Singleton` bean to an `@ApplicationScoped` bean for the test. | |
| This will convert the `@Singleton` bean to an `@ApplicationScoped` bean for the test. | |
| This is considered an advanced option and should only be performed if you fully understand the consequences of changing the scope of the bean |
glefloch
force-pushed
the
docs/mock-singleton
branch
from
9854f8a
to
5db85f2
Compare
glefloch
force-pushed
the
docs/mock-singleton
branch
from
5db85f2
to
d77d951
Compare
|
Thanks for the review, I removed the |
geoand
approved these changes
Jan 19, 2022
gsmet
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note about the
convertScopesproperty of@InjectMockthat allows mocking@Singletonbeans.