Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the messaging codestarts #23029

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix the messaging codestarts #23029

merged 1 commit into from
Jan 20, 2022

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Jan 19, 2022 •
edited

They could not work as they were implemented.
This PR simplifies the app and config and remove the MQTT code start.

Fix #23018

@cescoffier
Fix the messaging codestarts
d84d9e8 
They could not work as they were implemented.
This PR simplifies the app and config and remote the MQTT code start.

Fix quarkusio#23018
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Jan 19, 2022
maxandersen
maxandersen approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested both and I at least see the messages in the console.

I would have expected at least some mention in the readme on what class to go look in like resteasy gives link to the right URL.

But that can be done/improved seperately.

@geoand geoand merged commit ad516dc into quarkusio:main Jan 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 20, 2022
cescoffier added a commit to cescoffier/quarkus that referenced this pull request Jan 20, 2022
@cescoffier
Remove the MQTT codestart (dropped by quarkusio#23029)
6082884
@cescoffier cescoffier mentioned this pull request Jan 20, 2022
Merged
rsvoboda
rsvoboda reviewed Jan 20, 2022
View reviewed changes
...tartIT/testKafkaContent/src_test_java_ilove_quark_us_MyReactiveMessagingApplicationTest.java

@QuarkusTest
@QuarkusTestResource(MyReactiveMessagingApplicationTest.InMemoryChannelTestResource.class)
class MyReactiveMessagingApplicationTest {

@Inject
@Any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier any reason for @Any annotation here?

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 21, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jan 21, 2022
@cescoffier @gsmet
Remove the MQTT codestart (dropped by quarkusio#23029)
f73c729 
(cherry picked from commit 6082884)
@cescoffier cescoffier deleted the fix-messaging-codestarts branch March 15, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda left review comments

@maxandersen maxandersen maxandersen approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.

No messages emitted on start of smallrye-reactive-messaging-kafka codestart in dev mode
5 participants
@cescoffier @maxandersen @rsvoboda @gsmet @geoand