-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set current project file when initializing the Maven resolver in the bootstrap provider #23035
Set current project file when initializing the Maven resolver in the bootstrap provider #23035
Conversation
Well, in a sample project I'm still seeing the same exception as in https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/NPE.20when.20using.20quarkus.3Adev/near/268544477
I added some output right above the code you changed and I don't see it, so that part is not even invoked? |
I'll push a reproducer, stay tuned! |
@aloubyansky here we go: https://github.com/famod/modmono-quarkus/tree/npe-profiled-modules-dev (notice the branch)
|
Excellent, thanks! |
…bootstrap provider
cb4b3c7
to
1c177ac
Compare
Fixed, thanks @famod ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This helps when for example dev mode is launched for a module targeted with
-pl
and the parent POM enables that module in a profile. Although in such a case the workspace discovery might not be including all the modules enabled in the profile. To enable all the modules,quarkus.bootstrap.effective-model-builder
still has to be enabled.This little change also may appear as a slight optimization resolving the current project path.