Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for xray to work within aws http/rest extensions #23038

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

patriot1burke
Copy link
Contributor

Reverted code substitution as xray now looks within system properties

Fix #22595

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7dad206

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/amazon-lambda-http-resteasy integration-tests/amazon-lambda-s3event integration-tests/amazon-lambda-stream-handler 

📦 integration-tests/amazon-lambda-http-resteasy

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostEmpty - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.test404 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testCustomIDPSecurityContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testProxyRequestContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testGetText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostBinary - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-s3event

io.quarkus.it.amazon.lambda.S3EventTestCase.testS3 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-stream-handler

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testSimpleLambdaSuccess - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/amazon-lambda-http-resteasy integration-tests/amazon-lambda-s3event integration-tests/amazon-lambda-stream-handler 

📦 integration-tests/amazon-lambda-http-resteasy

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostEmpty - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.test404 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testCustomIDPSecurityContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testProxyRequestContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testGetText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostBinary - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-s3event

io.quarkus.it.amazon.lambda.S3EventTestCase.testS3 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-stream-handler

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testSimpleLambdaSuccess - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/amazon-lambda-http-resteasy integration-tests/amazon-lambda-s3event integration-tests/amazon-lambda-stream-handler 

📦 integration-tests/amazon-lambda-http-resteasy

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostEmpty - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.test404 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testCustomIDPSecurityContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testProxyRequestContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testGetText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostBinary - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testContext - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testPostText - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-s3event

io.quarkus.it.amazon.lambda.S3EventTestCase.testS3 - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

📦 integration-tests/amazon-lambda-stream-handler

io.quarkus.it.amazon.lambda.AmazonLambdaSimpleTestCase.testSimpleLambdaSuccess - More details - Source on GitHub

io.quarkus.amazon.lambda.test.LambdaException
	at io.quarkus.amazon.lambda.test.LambdaResourceManager$3.handleRequest(LambdaResourceManager.java:92)
	at io.undertow.server.RoutingHandler.handleRequest(RoutingHandler.java:92)

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building e6f8d08

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/amazon-lambda/common-runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/amazon-lambda-http/deployment and 22 more

📦 extensions/amazon-lambda/common-runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-amazon-lambda-common: File '/home/runner/work/quarkus/quarkus/extensions/amazon-lambda/common-runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AbstractLambdaPollLoop.java' has not been previously formatted. Please format file and commit before running validation!

null check

fix formatting
@paulrobinson
Copy link
Contributor

Requested in https://issues.redhat.com/browse/QUARKUS-1722, so proposing a backport to 2.7.

@radcortez
Copy link
Member

Requested in https://issues.redhat.com/browse/QUARKUS-1722, so proposing a backport to 2.7.

We are still waiting for confirmation that this fix actually solves the problem reported in #22595. Once we get confirmation, it should be fairly straightforward to backport.

@patriot1burke
Copy link
Contributor Author

@gsmet Needs to be backported to 2.7 branch and released with 2.7.1 (Customer issue).

@gsmet
Copy link
Member

gsmet commented Feb 5, 2022

@patriot1burke unless I'm mistaken, the current status is that I already backported it to 2.7.0.Final.

@gsmet
Copy link
Member

gsmet commented Feb 5, 2022

Yes, it's there: #23151 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants