Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document corellation between provided and generated k8s resources #23042

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Document corellation between provided and generated k8s resources #23042

merged 1 commit into from
Jan 21, 2022

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jan 20, 2022 •
edited

Resolves: #22975

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 20, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@iocanel iocanel requested a review from geoand January 20, 2022 07:49
@iocanel
Copy link
Contributor Author

iocanel commented Jan 20, 2022

cc @jonathanvila

@geoand
Copy link
Contributor

geoand commented Jan 20, 2022

What is byon?

@jonathanvila
Copy link

Thank you @iocanel 👍

@gsmet gsmet changed the title doc: corellation between byon and generated k8s resources Document corellation between byon and generated k8s resources Jan 20, 2022
@gsmet
Copy link
Member

gsmet commented Jan 20, 2022

@iocanel can you take into account the bot's feedback for your PR titles? It's important for our release notes. Thanks.

@iocanel
Copy link
Contributor Author

iocanel commented Jan 20, 2022

@iocanel can you take into account the bot's feedback for your PR titles? It's important for our release notes. Thanks.

Sorry about that. I keep on forgetting it.

@iocanel
Copy link
Contributor Author

iocanel commented Jan 20, 2022

What is byon?

B.Y.O is an acronym for bring your own. In our case it should be byor for bring your own resources.

@geoand geoand changed the title Document corellation between byon and generated k8s resources Document corellation between existing and generated k8s resources Jan 21, 2022
@geoand geoand changed the title Document corellation between existing and generated k8s resources Document corellation between provided and generated k8s resources Jan 21, 2022
@geoand
Copy link
Contributor

geoand commented Jan 21, 2022

2005 is calling!

https://www.youtube.com/watch?v=zUzd9KyIDrM

@geoand geoand merged commit eb61dfd into quarkusio:main Jan 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 21, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.7.0.Final
Development

Successfully merging this pull request may close these issues.

Document the customization of the minikube.yml and openshift.yaml
4 participants
@iocanel @geoand @jonathanvila @gsmet