Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid toUri call in QuarkusCompiler #23043

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

Postremus
Copy link
Member

and only retrieve one path from zfs, instead of always reading at least the root path

Relates to #21552

Saves about 10ms of dev mode startup time.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever tricks!

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼

@Postremus Postremus marked this pull request as draft January 20, 2022 11:27
@Postremus
Copy link
Member Author

I set this to draft, want to take a closer look at the test failures

@gsmet
Copy link
Member

gsmet commented Jan 20, 2022

@Postremus I see only MultiModuleKotlinProjectDevModeTest failing and it has been flaky for a while. Did you see anything else suspicious?

and only retrieve one path from zfs, instead of always reading at least the root path
@Postremus Postremus marked this pull request as ready for review January 22, 2022 19:51
@Postremus
Copy link
Member Author

Postremus commented Jan 22, 2022

@gsmet
I found it suspicious, that both gradle jobs failed at the same time, usually only one of them is.
With no pain-free way to check the logs (vacation / only phone with me), i wanted to look at it after I was back.

I force-pushed a rebase on latest main.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 23, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0598cfd

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/smallrye-context-propagation 

📦 integration-tests/smallrye-context-propagation

io.quarkus.context.test.mutiny.MutinyContextPropagationTest.testTransactionPropagationWithUni line 111 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.context.test.mutiny.MutinyContextPropagationTest 1 expectation failed.
Expected status code <409> but was <500>.

@gsmet gsmet merged commit 43baaf8 into quarkusio:main Jan 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 24, 2022
@Postremus Postremus deleted the everything-perf-teststuff branch January 24, 2022 12:51
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants