Use proper return type when indexing suspend functions #23060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirfx
reviewed
Jan 20, 2022
integration-tests/kotlin-serialization/src/main/kotlin/io/quarkus/it/kotser/GreetingResource.kt
Show resolved
Hide resolved
This was not a problem with Jackson or Jsonb, because they used the object class to determine the type of serializer, but it is needed for Kotlin serialization which actually used the generic type provided in the MessageBodyWriter params to determine the serializer Addresses: #quarkusio#9003 (comment)
geoand
force-pushed
the
suspend-kotlin-seriazation
branch
from
8084f95
to
c273a64
Compare
evanchooly
approved these changes
Jan 20, 2022
geoand
added
the
triage/waiting-for-ci
Failing Jobs - Building c273a64
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not a problem with Jackson or Jsonb, because they
used the object class to determine the type of serializer,
but it is needed for Kotlin serialization which actually
used the generic type provided in the MessageBodyWriter
params to determine the serializer
Addresses: #9003 (comment)